fix: link init hook when action is not nil

siyul-park · Dec 8, 2023 · db2af3b · db2af3b
1 parent b30d6e0
commit db2af3b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/pkg/node/onetomany.go b/pkg/node/onetomany.go
@@ -28,7 +28,7 @@ func NewOneToManyNode(action func(*process.Process, *packet.Packet) ([]*packet.P
 		errPort:  port.New(),
 	}
 
-	if action != nil {
+	if n.action != nil {
 		n.inPort.AddInitHook(port.InitHookFunc(n.forward))
 		n.errPort.AddInitHook(port.InitHookFunc(func(proc *process.Process) {
 			n.mu.RLock()
@@ -58,14 +58,16 @@ func (n *OneToManyNode) Port(name string) (*port.Port, bool) {
 			for j := 0; j <= i; j++ {
 				if len(n.outPorts) <= j {
 					outPort := port.New()
-					outPort.AddInitHook(port.InitHookFunc(func(proc *process.Process) {
-						n.mu.RLock()
-						defer n.mu.RUnlock()
+					if n.action != nil {
+						outPort.AddInitHook(port.InitHookFunc(func(proc *process.Process) {
+							n.mu.RLock()
+							defer n.mu.RUnlock()
 
-						outStream := outPort.Open(proc)
+							outStream := outPort.Open(proc)
 
-						n.backward(proc, outStream)
-					}))
+							n.backward(proc, outStream)
+						}))
+					}
 					n.outPorts = append(n.outPorts, outPort)
 				}
 			}

diff --git a/pkg/node/onetoone.go b/pkg/node/onetoone.go
@@ -30,7 +30,7 @@ func NewOneToOneNode(action func(*process.Process, *packet.Packet) (*packet.Pack
 		errPort: port.New(),
 	}
 
-	if action != nil {
+	if n.action != nil {
 		n.ioPort.AddInitHook(port.InitHookFunc(func(proc *process.Process) {
 			n.mu.RLock()
 			defer n.mu.RUnlock()