Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redesign compilation process #10

Merged
merged 25 commits into from
Nov 27, 2023
Merged

Conversation

siyul-park
Copy link
Owner

redesigning the compilation process, reducing the convoluted responsibilities in the Loader and transferring the linking process to a symbol table. To achieve this, we introduce a new symbol object that binds Specs and Nodes. Additionally, we remove the unnecessary Unload operation in the loader.

@siyul-park siyul-park added the enhancement New feature or request label Nov 26, 2023
@siyul-park siyul-park self-assigned this Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (b391d5d) 62.47% compared to head (17ead0a) 63.56%.

❗ Current head 17ead0a differs from pull request most recent head 4709006. Consider uploading reports for the commit 4709006 to get more accurate results

Files Patch % Lines
pkg/symbol/table.go 78.35% 24 Missing and 18 partials ⚠️
pkg/loader/loader.go 63.63% 16 Missing and 12 partials ⚠️
pkg/symbol/loadhook.go 0.00% 3 Missing ⚠️
pkg/symbol/unloadhook.go 0.00% 3 Missing ⚠️
pkg/hook/hook.go 80.00% 0 Missing and 2 partials ⚠️
pkg/loader/reconciler.go 85.71% 0 Missing and 1 partial ⚠️
pkg/runtime/runtime.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   62.47%   63.56%   +1.08%     
==========================================
  Files          77       76       -1     
  Lines        6687     6524     -163     
==========================================
- Hits         4178     4147      -31     
+ Misses       1914     1803     -111     
+ Partials      595      574      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siyul-park siyul-park force-pushed the feature/redesign_compile branch from 11b0dd2 to a0d7a7d Compare November 26, 2023 11:06
@siyul-park siyul-park merged commit b2de2a7 into main Nov 27, 2023
4 checks passed
@siyul-park siyul-park deleted the feature/redesign_compile branch November 27, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant