-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: redesign compilation process #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 62.47% 63.56% +1.08%
==========================================
Files 77 76 -1
Lines 6687 6524 -163
==========================================
- Hits 4178 4147 -31
+ Misses 1914 1803 -111
+ Partials 595 574 -21 ☔ View full report in Codecov by Sentry. |
siyul-park
force-pushed
the
feature/redesign_compile
branch
from
November 26, 2023 11:06
11b0dd2
to
a0d7a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redesigning the compilation process, reducing the convoluted responsibilities in the Loader and transferring the linking process to a symbol table. To achieve this, we introduce a new symbol object that binds Specs and Nodes. Additionally, we remove the unnecessary Unload operation in the loader.