Skip to content

feat: support json marshal in types #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

siyul-park
Copy link
Owner

Changes Made

Related Issues

Additional Information

@siyul-park siyul-park requested a review from ewlkkf February 4, 2025 15:22
@siyul-park siyul-park self-assigned this Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 64.75000% with 141 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (ffbe993) to head (af3ed4c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ext/pkg/mime/encoding.go 48.59% 37 Missing and 18 partials ⚠️
pkg/types/map.go 56.52% 24 Missing and 6 partials ⚠️
pkg/types/buffer.go 60.65% 17 Missing and 7 partials ⚠️
pkg/types/error.go 74.50% 9 Missing and 4 partials ⚠️
pkg/types/float.go 57.14% 4 Missing and 2 partials ⚠️
pkg/types/slice.go 70.00% 4 Missing and 2 partials ⚠️
pkg/types/binary.go 84.61% 3 Missing and 1 partial ⚠️
pkg/types/boolean.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   74.99%   75.11%   +0.12%     
==========================================
  Files         141      141              
  Lines       10673    10900     +227     
==========================================
+ Hits         8004     8188     +184     
- Misses       2007     2033      +26     
- Partials      662      679      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siyul-park siyul-park force-pushed the feature/support-json-marshal-in-types branch from b2ba72b to 81ff98c Compare February 4, 2025 15:44
@siyul-park siyul-park enabled auto-merge (squash) February 5, 2025 14:45
@siyul-park siyul-park merged commit 8746006 into main Feb 5, 2025
5 of 6 checks passed
@siyul-park siyul-park deleted the feature/support-json-marshal-in-types branch February 5, 2025 14:45
Copy link
Collaborator

@ewlkkf ewlkkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants