Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'get' command for retrieving and displaying applied resources #46

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

siyul-park
Copy link
Owner

Changes Made

  • Introduce a new get command to retrieve and display applied resources.
  • Enhance the command's description for improved clarity and natural language.
  • Refactor and modularize the existing code for better maintainability.
./uniflow get
 ID                          KIND    NAMESPACE  NAME    LINKS                                
 01HH8WSZC9RPTCCDQ9HDQ1TFFB  http    default    http    map[out:[map[name:router port:in]]]  
 01HH8WSZC9RPTCCDQ9HFEEQAYH  router  default    router  map[out[0]:[map[name:http port:in]]] 

Related Issues

Additional Information

@siyul-park siyul-park added the enhancement New feature or request label Dec 10, 2023
@siyul-park siyul-park self-assigned this Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (8a6d42f) 63.82% compared to head (a40bdcd) 63.91%.

Files Patch % Lines
cmd/uniflow/get/cmd.go 61.22% 13 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   63.82%   63.91%   +0.08%     
==========================================
  Files          78       79       +1     
  Lines        6557     6606      +49     
==========================================
+ Hits         4185     4222      +37     
- Misses       1825     1830       +5     
- Partials      547      554       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Seungwoo-Yu Seungwoo-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siyul-park siyul-park enabled auto-merge (squash) December 11, 2023 10:37
@siyul-park siyul-park merged commit 8a069c9 into main Dec 11, 2023
5 of 6 checks passed
@siyul-park siyul-park deleted the feature/add_get_cmd branch December 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants