Display correct shortcut for Strikethrough, depending on extension version #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion This ensures the correct mod+Shift+S shortcut is displayed by default (used in newer versions of the strike extension package), but uses mod+Shift+X if the extension is configured to use that shortcut, for users still on Tiptap <2.1.0 (for backwards compatibility).
|
Opened this PR for reference later, should this pattern be useful in other places, but I think given how long mod+Shift+S has been around (Tiptap is now on v2.10, and this shortcut was changed back in 2.1), it's better to avoid the complexity and overhead of checking what extension was configured, and instead just go with the simpler approach in #305 which always uses mod+Shift+S (and can be overridden by users of mui-tiptap like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the correct mod+Shift+S shortcut is displayed by default (used in newer versions of the strike extension package), but uses mod+Shift+X if the extension is configured to use that shortcut, for users still on Tiptap <2.1.0 (for backwards compatibility).
Alternative to the PR that just changes to mod+Shift+S by default #305, and would require users of Tiptap <2.1.0 to pass
<MenuButtonStrikethrough tooltipShortcutKeys={["mod", "Shift", "X"]} />.