Using index signature to access index properties

skaut · Jan 15, 2025 · 311ef8c · 311ef8c
1 parent 9412987
commit 311ef8c
Show file tree

Hide file tree

Showing 24 changed files with 53 additions and 57 deletions.
diff --git a/playwright.config.ts b/playwright.config.ts
@@ -1,7 +1,7 @@
 import { defineConfig, devices } from "@playwright/test";
 
 export default defineConfig({
-  forbidOnly: process.env.CI !== undefined,
+  forbidOnly: process.env["CI"] !== undefined,
   fullyParallel: true,
   projects: [
     {
@@ -17,18 +17,18 @@ export default defineConfig({
       use: { ...devices["Desktop Safari"] },
     },
   ],
-  reporter: process.env.CI !== undefined ? "html" : "list",
-  retries: process.env.CI !== undefined ? 2 : 0,
+  reporter: process.env["CI"] !== undefined ? "html" : "list",
+  retries: process.env["CI"] !== undefined ? 2 : 0,
   testDir: "./tests/frontend",
   use: {
     baseURL: "http://127.0.0.1:5173",
     trace: "on-first-retry",
   },
   webServer: {
     command: "npm run start -- --host",
-    reuseExistingServer: process.env.CI === undefined,
+    reuseExistingServer: process.env["CI"] === undefined,
     url: "http://127.0.0.1:5173",
   },
   // Opt out of parallel tests on CI.
-  //workers: process.env.CI !== undefined ? 1 : undefined,
+  //workers: process.env["CI"] !== undefined ? 1 : undefined,
 });
diff --git a/src/backend/index.ts b/src/backend/index.ts
@@ -7,7 +7,7 @@ import { move } from "./move";
 
 declare const globalThis: google.script.PublicEndpoints;
 
-globalThis.doGet = doGet;
-globalThis.listFolders = listFolders;
-globalThis.listSharedDrives = listSharedDrives;
-globalThis.move = move;
+globalThis["doGet"] = doGet;
+globalThis["listFolders"] = listFolders;
+globalThis["listSharedDrives"] = listSharedDrives;
+globalThis["move"] = move;
diff --git a/src/frontend/App.svelte b/src/frontend/App.svelte
@@ -119,13 +119,9 @@
     google.script.run
       .withSuccessHandler(moveSuccessHandler)
       .withFailureHandler(moveErrorHandler)
-      .move(
-        source.id,
-        destination.id,
-        copyComments,
-        mergeFolders,
-        forceNonEmpty,
-      );
+      [
+        "move"
+      ](source.id, destination.id, copyComments, mergeFolders, forceNonEmpty);
   }
 
   function showErrorDialogWithEvent(

diff --git a/src/frontend/FolderSelection.svelte b/src/frontend/FolderSelection.svelte
@@ -65,12 +65,12 @@
       google.script.run
         .withSuccessHandler(handleSharedDriveResponse)
         .withFailureHandler(handleError)
-        .listSharedDrives();
+        ["listSharedDrives"]();
     } else {
       google.script.run
         .withSuccessHandler(handleFolderResponse)
         .withFailureHandler(handleError)
-        .listFolders(path[path.length - 1].id);
+        ["listFolders"](path[path.length - 1].id);
     }
   }
 

diff --git a/tests/frontend/basic.spec.ts b/tests/frontend/basic.spec.ts
@@ -7,7 +7,7 @@ test("works with basic configuration", async ({ page }) => {
   const getCalls = await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -17,7 +17,7 @@ test("works with basic configuration", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { response: { errors: [] }, status: "success" },

diff --git a/tests/frontend/configuration.spec.ts b/tests/frontend/configuration.spec.ts
@@ -7,7 +7,7 @@ test("works with copy configuration", async ({ page }) => {
   const getCalls = await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -17,7 +17,7 @@ test("works with copy configuration", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { response: { errors: [] }, status: "success" },
@@ -53,7 +53,7 @@ test("works with merge configuration", async ({ page }) => {
   const getCalls = await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -63,7 +63,7 @@ test("works with merge configuration", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { response: { errors: [] }, status: "success" },

diff --git a/tests/frontend/destination-selection-api-error.spec.ts b/tests/frontend/destination-selection-api-error.spec.ts
@@ -9,13 +9,13 @@ test("handles raw errors in source folder selection gracefully", async ({
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listFolders = [
+    window._endpointStubs["listFolders"] = [
       {
         status: "success",
         value: { status: "error", type: "DriveAPIError" },
       },
     ];
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: {

diff --git a/tests/frontend/destination-selection-invalid-parameter-error.spec.ts b/tests/frontend/destination-selection-invalid-parameter-error.spec.ts
@@ -9,13 +9,13 @@ test("handles raw errors in source folder selection gracefully", async ({
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listFolders = [
+    window._endpointStubs["listFolders"] = [
       {
         status: "success",
         value: { status: "error", type: "invalidParameter" },
       },
     ];
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: {

diff --git a/tests/frontend/destination-selection-unhandled-error.spec.ts b/tests/frontend/destination-selection-unhandled-error.spec.ts
@@ -9,13 +9,13 @@ test("handles raw errors in source folder selection gracefully", async ({
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listFolders = [
+    window._endpointStubs["listFolders"] = [
       {
         status: "failure",
         value: new Error("ERROR MESSAGE"),
       },
     ];
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: {

diff --git a/tests/frontend/destination-selection-unknown-error.spec.ts b/tests/frontend/destination-selection-unknown-error.spec.ts
@@ -9,13 +9,13 @@ test("handles raw errors in source folder selection gracefully", async ({
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listFolders = [
+    window._endpointStubs["listFolders"] = [
       {
         status: "success",
         value: { status: "error", type: "unknown" },
       },
     ];
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: {

diff --git a/tests/frontend/move-api-error.spec.ts b/tests/frontend/move-api-error.spec.ts
@@ -7,7 +7,7 @@ test("works with an API error", async ({ page }) => {
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -17,7 +17,7 @@ test("works with an API error", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { status: "error", type: "DriveAPIError" },

diff --git a/tests/frontend/move-folders-equal-error.spec.ts b/tests/frontend/move-folders-equal-error.spec.ts
@@ -9,7 +9,7 @@ test("works with source and destination folders being equal", async ({
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -19,7 +19,7 @@ test("works with source and destination folders being equal", async ({
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { status: "error", type: "sourceEqualsDestination" },

diff --git a/tests/frontend/move-invalid-parameter-error.spec.ts b/tests/frontend/move-invalid-parameter-error.spec.ts
@@ -7,7 +7,7 @@ test("works with an API error", async ({ page }) => {
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -17,7 +17,7 @@ test("works with an API error", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { status: "error", type: "invalidParameter" },

diff --git a/tests/frontend/move-repeat-after-timeout.spec.ts b/tests/frontend/move-repeat-after-timeout.spec.ts
@@ -9,7 +9,7 @@ test("works with an unhandled move error", async ({ page }) => {
   await page.evaluate(() => {
     const e = new Error();
     e.name = "ScriptError";
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -19,7 +19,7 @@ test("works with an unhandled move error", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "failure",
         value: e,

diff --git a/tests/frontend/move-unhandled-error.spec.ts b/tests/frontend/move-unhandled-error.spec.ts
@@ -7,7 +7,7 @@ test("works with an unhandled move error", async ({ page }) => {
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -17,7 +17,7 @@ test("works with an unhandled move error", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "failure",
         value: new Error("ERROR MESSAGE"),

diff --git a/tests/frontend/move-unknown-error.spec.ts b/tests/frontend/move-unknown-error.spec.ts
@@ -7,7 +7,7 @@ test("works with an unknown move error", async ({ page }) => {
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -17,7 +17,7 @@ test("works with an unknown move error", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { status: "error", type: "unknown" },

diff --git a/tests/frontend/navigation.spec.ts b/tests/frontend/navigation.spec.ts
@@ -7,7 +7,7 @@ test("works with basic configuration", async ({ page }) => {
   const getCalls = await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -33,7 +33,7 @@ test("works with basic configuration", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { response: { errors: [] }, status: "success" },

diff --git a/tests/frontend/non-empty.spec.ts b/tests/frontend/non-empty.spec.ts
@@ -7,7 +7,7 @@ test("works with non-empty destination folder", async ({ page }) => {
   const getCalls = await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { response: [], status: "success" },
@@ -21,7 +21,7 @@ test("works with non-empty destination folder", async ({ page }) => {
         value: { response: [], status: "success" },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         delay: 500,
         status: "success",

diff --git a/tests/frontend/source-destination-selection.spec.ts b/tests/frontend/source-destination-selection.spec.ts
@@ -7,7 +7,7 @@ test("works with folder selection", async ({ page }) => {
   const getCalls = await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listFolders = [
+    window._endpointStubs["listFolders"] = [
       {
         status: "success",
         value: {
@@ -96,7 +96,7 @@ test("works with folder selection", async ({ page }) => {
         },
       },
     ];
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: {
@@ -138,7 +138,7 @@ test("works with folder selection", async ({ page }) => {
         },
       },
     ];
-    window._endpointStubs.move = [
+    window._endpointStubs["move"] = [
       {
         status: "success",
         value: { response: { errors: [] }, status: "success" },

diff --git a/tests/frontend/source-selection-api-error.spec.ts b/tests/frontend/source-selection-api-error.spec.ts
@@ -9,7 +9,7 @@ test("handles raw errors in source folder selection gracefully", async ({
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { status: "error", type: "DriveAPIError" },

diff --git a/tests/frontend/source-selection-invalid-parameter-error.spec.ts b/tests/frontend/source-selection-invalid-parameter-error.spec.ts
@@ -9,7 +9,7 @@ test("handles invalid parameter errors in source folder selection gracefully", a
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "success",
         value: { status: "error", type: "invalidParameter" },

diff --git a/tests/frontend/source-selection-unhandled-error.spec.ts b/tests/frontend/source-selection-unhandled-error.spec.ts
@@ -9,7 +9,7 @@ test("handles raw errors in source folder selection gracefully", async ({
   await setup(page);
 
   await page.evaluate(() => {
-    window._endpointStubs.listSharedDrives = [
+    window._endpointStubs["listSharedDrives"] = [
       {
         status: "failure",
         value: new Error("ERROR MESSAGE"),