Skip to content

[24958] Replace remaining 4 KB-aligned native libs for 16 KB Play policy#522

Open
sg-jsonjuliane wants to merge 1 commit intodevelopfrom
refactor/24958-16kb-compliance
Open

[24958] Replace remaining 4 KB-aligned native libs for 16 KB Play policy#522
sg-jsonjuliane wants to merge 1 commit intodevelopfrom
refactor/24958-16kb-compliance

Conversation

@sg-jsonjuliane
Copy link
Contributor

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

  • Type: Refactor
  • Issue Link: Redmine Issue #24958
  • Risk Factor: Low - Dependency version updates only. All updates are backward compatible and tested.

Changes

16KB page size compliance dependency updates.

  • Updated compileSdkVersion from 34 to 35 (required by updated dependencies)
  • Updated Instabug SDK from 13.0.1 to 13.4.0 (13.4.0+ required for 16KB page size support)
  • Updated Google ML Kit Barcode Scanning from 16.0.0 to 17.3.0 (16KB page size support)

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: No code changes. Only dependency version updates.
  • Architectural Patterns: No architectural changes.

Testing and Reliability

  • Unit Testing: Existing tests should pass. No API breaking changes in updated dependencies.
  • Emulator and Real Device Testing: All functionality verified. QR code scanning works with ML Kit 17.3.0.

Error Handling and Logging

  • Error Handling: No changes to error handling.
  • Logging: No changes to logging.

16KB Compliance Specific

  • Dependency Updates: All dependencies updated to 16KB-compatible versions
  • compileSdkVersion: Updated to 35 as required by dependencies
  • Backward Compatibility: All updates maintain API compatibility

Testing Procedure

Steps to verify the dependency updates.

  1. Build Verification:

    ./gradlew build
    ./gradlew :tripkit-android:assembleRelease
  2. Dependency Verification:

    ./gradlew :tripkit-android:dependencies | grep -E "instabug|mlkit|compileSdk"
    # Should show:
    # - Instabug: 13.4.0
    # - ML Kit: 17.3.0
    # - compileSdk: 35
  3. Integration Testing:

    • Verify app builds successfully when using this module
    • Verify QR code scanning works (ML Kit)
    • Verify bug reporting works (Instabug)
    • Verify no crashes or regressions
  4. 16KB Compliance Verification:

    • Native libraries from these dependencies should be 16KB aligned
    • Verify with main app's verification script

Work-in-Progress (WIP)

No remaining work. Implementation is complete.

  • All dependencies updated to 16KB-compatible versions
  • compileSdkVersion updated
  • All changes tested and verified

Notes

  • Instabug 13.4.0: Required for 16KB page size support. Previous versions (13.0.1, 13.3.0) do not support 16KB alignment.
  • ML Kit 17.3.0: Provides 16KB-aligned libbarhopper_v3.so. Note: Package structure changed (Barcode class moved to .common package), but code changes are handled in tripkit-android-ui module.
  • compileSdkVersion 35: Required by androidx.core:core-ktx:1.16.0 which is a transitive dependency of the updated PDF Viewer library.
  • No Breaking Changes: All dependency updates maintain API compatibility. Code changes for API compatibility are in the tripkit-android-ui module.

- Update ML Kit barcode-scanning to 17.3.0 (16KB support)
- Update Instabug to 13.4.0 (16KB support)
- Update compileSdkVersion to 35 (required by dependencies)
@github-actions
Copy link

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

This pull request is stale because it has been open 5 days with no activity.

@github-actions github-actions bot added the Stale label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant