Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename domain in database #1

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Rename domain in database #1

wants to merge 2 commits into from

Conversation

andypost
Copy link

COuld get speed-up by

  • moving updates into single transaction

  • minimize amount of look-ups to disctionary and DB

  • Requires to update other tables (relations) separate

  • TODO check content hash

  • Also depends on cascade foregn keys (may need to revert back after migration)

ALTER TABLE event_edges
DROP CONSTRAINT event_edges_event_id_fkey,
ADD CONSTRAINT event_edges_event_id_fkey
    FOREIGN KEY (event_id)
    REFERENCES events(event_id)
    ON UPDATE CASCADE;

ALTER TABLE event_forward_extremities
DROP CONSTRAINT event_forward_extremities_event_id,
ADD CONSTRAINT event_forward_extremities_event_id
    FOREIGN KEY (event_id)
    REFERENCES events(event_id)
    ON UPDATE CASCADE;

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

COuld get speed-up by
- moving updates into single transaction
- minimize amount of look-ups to disctionary and DB

- Requires to update other tables (relations) separate
- TODO check content hash

- Also depends on cascade foregn keys (may need to revert back after migration)
```
ALTER TABLE event_edges
DROP CONSTRAINT event_edges_event_id_fkey,
ADD CONSTRAINT event_edges_event_id_fkey
    FOREIGN KEY (event_id)
    REFERENCES events(event_id)
    ON UPDATE CASCADE;

ALTER TABLE event_forward_extremities
DROP CONSTRAINT event_forward_extremities_event_id,
ADD CONSTRAINT event_forward_extremities_event_id
    FOREIGN KEY (event_id)
    REFERENCES events(event_id)
    ON UPDATE CASCADE;
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant