Address PR review feedback: code style and validation fixes #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses unresolved review comments from PR #2 review thread.
Changes
planewave.py,exchange_legendre.py,pyproject.tomlsign_magneticfieldvalidation inget_form_factors()public APIVeff = Noneassignment inexchange_legendre.pytest_validation.py(tolerance is 3e-3, not 1e-4)lru_cache(maxsize=None)→cache, removed unnecessary string quotes from type annotationsAll 18 tests pass.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.