Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change KubeCmdClient API for namespaced and custer wide commands #122

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jul 3, 2024

Description

Changes for KubeCmdClient API wiith namespaced and cluster wide comands.
Old behavior caused confuses with commands like execInCurrentNamespace etc.. so there is a change to use it similar like f8 API
So in new way if use call cmdCli.inNamespace("ns").list(... call commands with --namespace ns but when user uses cmdCli.list... it call command without --namespace arg

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys added the enhancement New feature or request label Jul 3, 2024
@kornys kornys self-assigned this Jul 3, 2024
@github-actions github-actions bot requested review from Frawless and im-konge July 3, 2024 18:58
@kornys kornys merged commit 5676820 into main Jul 4, 2024
7 checks passed
@kornys kornys deleted the kcmd-api-namespace branch July 4, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Change api of KubeCmdClient from execInCurrentNamespace to exec when namespace is specified
3 participants