Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GlobalLogCollector for automatic collecting logs when test fails #124

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Implement GlobalLogCollector for automatic collecting logs when test fails #124

merged 1 commit into from
Jul 11, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jul 8, 2024 •
edited
Loading

Description

Add ability to users to just specify stuff for global log collector which is automatically called on fail events in test and before/after methods.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys added the enhancement New feature or request label Jul 8, 2024
@kornys kornys self-assigned this Jul 8, 2024
@kornys kornys linked an issue Jul 8, 2024 that may be closed by this pull request
[Enhancement]: Create functionality for users to automatically collect logs when test fails #118
Closed
@kornys kornys marked this pull request as ready for review July 8, 2024 08:22
@github-actions github-actions bot requested review from Frawless and im-konge July 8, 2024 08:22
@kornys kornys requested review from see-quick and obabec July 8, 2024 08:34
@kornys kornys added this to the 0.2.0 milestone Jul 8, 2024
@kornys kornys force-pushed the glogal-log-collector branch from c7f694c to c99a62c Compare July 9, 2024 14:10
@kornys
Implement GlobalLogCollector for automatic collecting logs when test …
9eabef2 
…fails

Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys force-pushed the glogal-log-collector branch from 2632fac to 9eabef2 Compare July 10, 2024 08:29
@kornys kornys merged commit 1c7e032 into main Jul 11, 2024
6 checks passed
@kornys kornys deleted the glogal-log-collector branch July 11, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frawless Frawless Frawless approved these changes

@obabec obabec obabec approved these changes

@see-quick see-quick see-quick approved these changes

@im-konge im-konge Awaiting requested review from im-konge

Assignees

@kornys kornys

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Create functionality for users to automatically collect logs when test fails
4 participants
@kornys @Frawless @obabec @see-quick