Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change KubeResourceManager API #209

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Change KubeResourceManager API #209

merged 1 commit into from
Jan 9, 2025

Conversation

kornys
Copy link
Member

@kornys kornys commented Jan 9, 2025

Description

Change API of KubeResoruceManager

  1. deprecated getInstance() method and use instead of get() method for getting instance
  2. Context set/get methods moved from static to non-static
  3. YAML path configuration method moved from static to non static

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys added the enhancement New feature or request label Jan 9, 2025
@kornys kornys added this to the 0.10.0 milestone Jan 9, 2025
@kornys kornys self-assigned this Jan 9, 2025
@github-actions github-actions bot requested review from Frawless and im-konge January 9, 2025 10:49
@kornys kornys merged commit 86a19e4 into main Jan 9, 2025
7 checks passed
@kornys kornys deleted the krm-api-v1beta branch January 9, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants