-
Notifications
You must be signed in to change notification settings - Fork 390
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Fix issues with sklearn 1.4 Some skorch tests fail with sklearn v1.4. This commit fixes them: 1. Inheritance structure of scorers seems to have changed. 2. classes_ attribute should always be numpy array 3. CalibratedClassifierCV only works with predict_proba being float64 To fix the latter, I'm now casting the output of predict_proba to float64. However, I'm not sure if this is a good idea, as it might break existing code. I'm just adding it in for now to check if the tests pass. * Fix test after changing type of classes_ * Make CCCV test xfail for the time being * Set xfail non-strict bc test pass with old sklearn For Python 3.8, an older sklearn version (1.3.2) is installed, which does not result in the test failing. Therefore, instead of requiring a strict xfail, make xfail optional.
- Loading branch information
1 parent
0d3a8ec
commit 1f7a779
Showing
3 changed files
with
14 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters