Add PyTorch 2.5.0 to CI #1069
Open
Add PyTorch 2.5.0 to CI #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop 2.1.2, update 2.4.0 to 2.4.1
|
|
Protobuf still uses utcnow, which now gives a deprecation warning.
Python 3.12 requires torch >= 2.4 for compile to work.
thomasjpfan
reviewed
Oct 18, 2024
Comment on lines
+139
to
+144
| w_list = [ | ||
| warning for warning in recwarn.list | ||
| if "protobuf" not in warning.message.args[0] | ||
| and "utcnow" not in warning.message.args[0] | ||
| ] | ||
| w0, w1 = w_list # one warning for train, one for valid |
There was a problem hiding this comment.
Assuming two warnings by coming out of this filter can be a bit flaky. Can we directly pull out the warnings from training and validation warnings?
There was a problem hiding this comment.
Yeah, I thought so too. Do you have an elegant solution for that? I was wondering if there was an API for setting filters to recwarn but I didn't see anything.
At least, with this implementation, we catch unexpected warnings ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weights_onlyas that trips up some warning testsutcnowby protobuftorch.compiletests when torch < 2.4 and Python 3.12 are used, as this is not supported by torchNote that I had to upgrade torch and Python at the same time because torch 2.5 requires Python > 3.8 and because Python 3.12 requires torch > 2.1 (which is dropped in favor of 2.5).