Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first try adding a table of provided options #1

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

mirpedrol
Copy link

@mirpedrol mirpedrol commented Feb 22, 2024

Address comment in nextflow-io#89

image

@@ -183,6 +183,7 @@ class CO2FootprintFactory implements TraceObserverFactory {
*/
// nm: size of memory available [GB] -> requested memory
Long memory = trace.get('memory') as Long
memory = 1000000
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirpedrol where is this coming from? was this for testing maybe?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, it was indeed for testing! I committed it by mistake

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the rest can stay at it is? Then I will use it

@skrakau skrakau merged commit 1bc7245 into skrakau:report_params Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants