Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing method inspection #4

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: failing method inspection #4

merged 1 commit into from
Aug 26, 2024

Conversation

skryukov
Copy link
Owner

Possible fix for #1

@skryukov
Copy link
Owner Author

@davidrunger could you check if this solution works for you?

@davidrunger
Copy link
Contributor

@skryukov Thank you for looking into it!

After figuring out a way to reliably reproduce the issue, yes, I can confirm that this change does fix it. 🙌

And, FWIW, I think that the approach you are taking here is good. I will close #3 in favor of this PR.

@davidrunger davidrunger mentioned this pull request Aug 26, 2024
Closed
@skryukov skryukov merged commit 5f7484a into main Aug 26, 2024
5 checks passed
@skryukov skryukov deleted the fix-method-inspection branch August 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skryukov @davidrunger