Refactor to a regex-based algorithm #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to enhance the speed of
URI::IDNA::UTS46
, bringing it up to par with the speed of the pure IDNA algorithm from Addressable. Achieving this could enableURI::IDNA::UTS46
to be used as a default IDNA-algorithm in Addressable without significant performance trade-offs.To accomplish this, this PR introduces several changes to the internal implementation algorithm—it includes additional checks for
ascii_only?
, as suggested in the ruby/ruby#8966 for Ruby, and replaces loops over characters/code points with regular expressions, among other minor enhancements. Additionally. This PR also includes more unit-tests for validation logic, yay 🎉To assess the performance improvements, I used a modified version of the addressable benchmark:
Results (MacBook Pro 13", M1, 2020, 16GB, ruby v3.2.2):