-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minhop issue #91
Merged
Merged
Fix minhop issue #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or make sure minhop satistifed
…lse should pass it with hide value, like ?selfTransports=hide&...
0pcom
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
selfTransport
to transport discovery as URL query value, likehttps://tpd.skywire.dev/all-transports?selfTransports=hide
that never show self-transports by visors. It is useful on route finder and also in node visualizerHow to test?:
docker
folder:visor*.json
files indocker/integration
folderdocker-compose.yml
file indocker
folderArchive.zip
make integration-env-build
Note:
We should move from BFS (current solution) to Bidirectional A* for functionality in scale of our network. Look at these:
For now (and our current network scale) this algorithm is enough, but for later, we should move to Bidirectional A*: