Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minhop issue #91

Merged
merged 19 commits into from
Jan 26, 2025
Merged

Fix minhop issue #91

merged 19 commits into from
Jan 26, 2025

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Jan 13, 2025

Changes:

  • add selfTransport to transport discovery as URL query value, like https://tpd.skywire.dev/all-transports?selfTransports=hide that never show self-transports by visors. It is useful on route finder and also in node visualizer
  • add some new visor config to integration env for test minhop
  • fix some docker config issues
  • remove old useless algorithm Dijkstra and replace it with Finder (modified BFS) algorithm

How to test?:

  • Put these additional configs and replace exists in docker folder:
    • visor*.json files in docker/integration folder
    • docker-compose.yml file in docker folder
      Archive.zip
  • run integration env by make integration-env-build
  • check visorC logs for route with minhop=4
  • you can start app on other visors by change configs too and check minhop functionality

Note:
We should move from BFS (current solution) to Bidirectional A* for functionality in scale of our network. Look at these:

telegram-cloud-photo-size-1-4931948205294334055-x

For now (and our current network scale) this algorithm is enough, but for later, we should move to Bidirectional A*:

telegram-cloud-photo-size-1-4931948205294334056-x

@mrpalide mrpalide closed this Jan 20, 2025
@mrpalide mrpalide reopened this Jan 20, 2025
@mrpalide mrpalide marked this pull request as ready for review January 20, 2025 12:51
@mrpalide mrpalide changed the title [WIP] Fix minhop issue Fix minhop issue Jan 20, 2025
@0pcom 0pcom self-requested a review January 23, 2025 16:48
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mrpalide mrpalide merged commit 0f29312 into skycoin:develop Jan 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants