Skip to content

workflow: add ping-mesh workflow #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

workflow: add ping-mesh workflow #1640

wants to merge 1 commit into from

Conversation

@dvandra
Copy link
Contributor

@dvandra dvandra commented Jan 31, 2019

Check connectivity from/to multiple points at once

nplanel
nplanel reviewed Jan 31, 2019
View reviewed changes
@nplanel
Copy link
Member

nplanel commented Feb 1, 2019

please squash your commits

nplanel
nplanel reviewed Feb 1, 2019
View reviewed changes
nplanel
nplanel reviewed Feb 1, 2019
View reviewed changes
@dvandra dvandra force-pushed the workflows_pingmesh branch 2 times, most recently from 3ce5113 to 15c8d08 Compare February 4, 2019 07:37
nplanel
nplanel reviewed Feb 4, 2019
View reviewed changes
@dvandra dvandra force-pushed the workflows_pingmesh branch 4 times, most recently from 506df31 to eb31dd0 Compare February 7, 2019 10:41
@nplanel nplanel force-pushed the workflows_pingmesh branch from eb31dd0 to 54bf4af Compare February 8, 2019 15:21
@masco
Copy link
Member

masco commented Feb 20, 2019

You need to rebase and change the parameter names according to the new yaml tags

masco
masco reviewed Feb 22, 2019
View reviewed changes
statics/workflows/ping-mesh.yaml
});
}).then(function () {
return result
}).finally(function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order should be catch and finally

@eranra
Copy link
Contributor

eranra commented Feb 27, 2019

Hi @dvandra & @masco-enovance I was looking on this today, trying to make this work. It look os ok, but not working so well. I was able to get Connected field green but the replied was red both for ICMP and for TCP. I am running this on my laptop with the scale demo script.

image

Also ... if you have any future plans to enhance and you can share it will be good ... we would like to enhance this workflow with the help of some students if possible so we want to sync on plans forward.

@nplanel
Copy link
Member

nplanel commented Feb 27, 2019

run tests

nplanel
nplanel reviewed Feb 27, 2019
View reviewed changes
@nplanel
Copy link
Member

nplanel commented Feb 27, 2019

@eranra I did a review, and packets are not injected correctly, that's why you having random behaviour
Note that in TCP or UDP mode, ports source and destination are random for each test (in ICMP it's his ID)

@nplanel nplanel added the wip label Feb 27, 2019
@eranra
Copy link
Contributor

eranra commented Feb 27, 2019

@nplanel thanks ... I want to sync on plans for this workflow as we want to get some students to potentially work in this area and want to know there is no overlap with @dvandra / others ... so if you can share it will be good.

@nplanel
Copy link
Member

nplanel commented Feb 27, 2019

@eranra We have a doc with somes workflows/use cases ideas. I can share and we can discuss about that tomorrow during the weekly

@dvandra
Copy link
Contributor Author

dvandra commented Feb 27, 2019 •
edited
Loading

Hi @dvandra & @masco-enovance I was looking on this today, trying to make this work. It look os ok, but not working so well. I was able to get Connected field green but the replied was red both for ICMP and for TCP. I am running this on my laptop with the scale demo script.

image

Also ... if you have any future plans to enhance and you can share it will be good ... we would like to enhance this workflow with the help of some students if possible so we want to sync on plans forward.

May be now it is working.

screenshot from 2019-02-28 00-21-25

@dvandra dvandra closed this Feb 27, 2019
@dvandra dvandra reopened this Feb 27, 2019
nplanel
nplanel reviewed Feb 28, 2019
View reviewed changes
@dvandra dvandra force-pushed the workflows_pingmesh branch 2 times, most recently from dd8ba4a to f74f52a Compare March 5, 2019 21:40
nplanel
nplanel requested changes Mar 6, 2019
View reviewed changes
statics/workflows/ping-mesh.yaml
var pktform = {};
client.gremlin.query(src).then(function(nodes) {
nodes.forEach(function(node) {
sources.push(node.Metadata.TID);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just avoid to add the node in sources when dst == node.Metadata.T

@dvandra dvandra force-pushed the workflows_pingmesh branch from f74f52a to 04e727a Compare March 6, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masco masco masco left review comments

@nplanel nplanel nplanel requested changes

Assignees

No one assigned

Labels

wip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dvandra @nplanel @masco @eranra @safchain