fix: script for ssh host key setup

The script only should run once and disable itself. It should also be not
enabled by default and should be started by an extra mdata / zoneinit script.

copy/opt/core/lib/svc/manifest/ssh-hostkey-mdata-setup.xml

@@ -2,7 +2,7 @@
 <!DOCTYPE service_bundle SYSTEM "/usr/share/lib/xml/dtd/service_bundle.dtd.1">
 <service_bundle type="manifest" name="ssh-hostkey-mdata-setup">
     <service name="network/ssh-hostkey-mdata-setup" type="service" version="1">
-        <create_default_instance enabled="true"/>
+        <create_default_instance enabled="false"/>
         <single_instance/>
         <dependency name="network" grouping="require_all" restart_on="error" type="service">
             <service_fmri value="svc:/milestone/network:default"/>
@@ -15,9 +15,6 @@
         </dependency>
         <exec_method type="method" name="start" exec="/opt/core/lib/svc/method/ssh-hostkey-mdata-setup" timeout_seconds="60"/>
         <exec_method type="method" name="stop" exec="true" timeout_seconds="60"/>
-        <property_group name='application' type='application'>
-            <propval name='done' type='boolean' value='false'/>
-        </property_group>
         <property_group name="startd" type="framework">
             <propval name="duration" type="astring" value="transient"/>
             <propval name="ignore_error" type="astring" value="core,signal"/>

copy/opt/core/lib/svc/method/ssh-hostkey-mdata-setup

@@ -6,9 +6,8 @@
 # Set basedir and default config file
 SSH_HOSTS='/var/ssh'
 
-# Do nothing if not under SMF, not provisioning, or already done.
-if [[ ! "${SMF_METHOD}" == "start" ]] || \
-   [[ $(svcprop -p application/done ssh-hostkey-mdata-setup) =~ true ]]; then
+# Do nothing if not under SMF
+if [[ ! "${SMF_METHOD}" == "start" ]]; then
 	exit ${SMF_EXIT_OK}
 fi
 
@@ -24,9 +23,7 @@ for key in dsa_key dsa_key.pub rsa_key rsa_key.pub; do
 	fi
 done
 
-# Setup service to run only once
-svccfg -s svc:/network/ssh-hostkey-mdata-setup 'setprop application/done = true'
-svcadm refresh svc:/network/ssh-hostkey-mdata-setup
+# Disable service after run once
 svcadm disable svc:/network/ssh-hostkey-mdata-setup
 
 exit ${SMF_EXIT_OK}

copy/opt/core/var/mdata-setup/includes/99-ssh-hostkey-mdata-setup.sh

@@ -0,0 +1 @@
+svcadm enable svc:/network/ssh-hostkey-mdata-setup:default