Updated for Stable & Expanded VAMP Usage#2
Open
SkyTech6 wants to merge 1 commit intoskythebro:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BepInEx is now stable on Thunderstore and I saw you were using VAMP. I've updated the csproj references for VCF and VAMP (I switched to UnhollowedX as it's more updated than the normal Unhollowed).
As well I've went ahead and simplified a lot of the calls to get managed systems and other minor changes for things that VAMP has already got the references for; rather minor optimizations but VAMP tries it's best to minimize how often we need to be getting these things constantly.
Biggest change is I removed the initialization patch; VAMP has an event for this (VAMP.Events.OnCoreLoaded) that I've subscribed your Initialize method to.
As well I switched out the hardcoded PrefabGUID references to use VAMP.Data.Prefabs list. That way if the prefab guids are updated in the future KillSpiders won't require an update just for those.