Add UnfurlLinks and UnfurlMedia to WebhookMessage #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lheiskan
commented
Jun 22, 2023
•
lheiskan
commented
- to support 'classic unfurl' configuration options in webhook messages.
- https://api.slack.com/reference/messaging/link-unfurling#classic_unfurl
- addresses Support link unfurling properties in slack.WebhookMessage #1207
* to support 'classic unfurl' configuration options in webhook messages. * https://api.slack.com/reference/messaging/link-unfurling#classic_unfurl
lorenzoaiello
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Thank you for your contribution @lheiskan !
This is a backwards-compatible change that exposed more control in the unfurling behavior when posting to Slack and is documented in the published Messaging Reference for link-unfurling. Test changes are not necessary as the defaults result in no behavioral changes and the current test coverage does not coverage contractual variances.
renovate bot
referenced
this pull request
in validator-labs/validator
Jul 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/slack-go/slack](https://togithub.com/slack-go/slack) | `v0.13.0` -> `v0.13.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>slack-go/slack (github.com/slack-go/slack)</summary> ### [`v0.13.1`](https://togithub.com/slack-go/slack/releases/tag/v0.13.1) [Compare Source](https://togithub.com/slack-go/slack/compare/v0.13.0...v0.13.1) #### What's Changed v0.13.1 is now available. It contains **no breaking changes** but does expose some new fields previously unavailable. ##### Enhancements - Added `UnfurlLinks` and `UnfurlMedia` to `WebhookMessage` by [@​lheiskan](https://togithub.com/lheiskan) in [https://github.com/slack-go/slack/pull/1208](https://togithub.com/slack-go/slack/pull/1208) - Added `isReadOnly` property to `Conversation` struct by [@​GGonryun](https://togithub.com/GGonryun) in [https://github.com/slack-go/slack/pull/1232](https://togithub.com/slack-go/slack/pull/1232) ##### Bug Fixes - Fixed `UploadFileV2` when using text content by [@​calebmckay](https://togithub.com/calebmckay) in [https://github.com/slack-go/slack/pull/1291](https://togithub.com/slack-go/slack/pull/1291) - Made `Channel` optional on `UploadFileV2` by [@​0xdeafcafe](https://togithub.com/0xdeafcafe) in [https://github.com/slack-go/slack/pull/1293](https://togithub.com/slack-go/slack/pull/1293) ##### Chores / Code Cleanup - Replace a Loop with Slice by [@​testwill](https://togithub.com/testwill) in [https://github.com/slack-go/slack/pull/1211](https://togithub.com/slack-go/slack/pull/1211) - Added Deprecation Notice for `files.upload` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1300](https://togithub.com/slack-go/slack/pull/1300) - Added Go Test Coverage for 1.21 and 1.22 by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1298](https://togithub.com/slack-go/slack/pull/1298) ##### Documentation Updates - Updated Inline Docs and API References by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1299](https://togithub.com/slack-go/slack/pull/1299) - Added an example for `Pagination` by [@​adamrothman](https://togithub.com/adamrothman) in [https://github.com/slack-go/slack/pull/1201](https://togithub.com/slack-go/slack/pull/1201) - Added an example for `ConversationHistory` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1302](https://togithub.com/slack-go/slack/pull/1302) - Added an example for `AddRemoteFile` and `DeleteFile` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1303](https://togithub.com/slack-go/slack/pull/1303) #### New Contributors - [@​calebmckay](https://togithub.com/calebmckay) made their first contribution in [https://github.com/slack-go/slack/pull/1291](https://togithub.com/slack-go/slack/pull/1291) - [@​lheiskan](https://togithub.com/lheiskan) made their first contribution in [https://github.com/slack-go/slack/pull/1208](https://togithub.com/slack-go/slack/pull/1208) - [@​GGonryun](https://togithub.com/GGonryun) made their first contribution in [https://github.com/slack-go/slack/pull/1232](https://togithub.com/slack-go/slack/pull/1232) - [@​0xdeafcafe](https://togithub.com/0xdeafcafe) made their first contribution in [https://github.com/slack-go/slack/pull/1293](https://togithub.com/slack-go/slack/pull/1293) - [@​lorenzoaiello](https://togithub.com/lorenzoaiello) made their first contribution in [https://github.com/slack-go/slack/pull/1300](https://togithub.com/slack-go/slack/pull/1300) - [@​adamrothman](https://togithub.com/adamrothman) made their first contribution in [https://github.com/slack-go/slack/pull/1201](https://togithub.com/slack-go/slack/pull/1201) **Full Changelog**: slack-go/slack@v0.13.0...v0.13.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnbyJdfQ==--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
ymotongpoo
referenced
this pull request
in ymotongpoo/opentelemetry-collector-extra
Aug 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/slack-go/slack](https://togithub.com/slack-go/slack) | `v0.13.0` -> `v0.13.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>slack-go/slack (github.com/slack-go/slack)</summary> ### [`v0.13.1`](https://togithub.com/slack-go/slack/releases/tag/v0.13.1) [Compare Source](https://togithub.com/slack-go/slack/compare/v0.13.0...v0.13.1) #### What's Changed v0.13.1 is now available. It contains **no breaking changes** but does expose some new fields previously unavailable. ##### Enhancements - Added `UnfurlLinks` and `UnfurlMedia` to `WebhookMessage` by [@​lheiskan](https://togithub.com/lheiskan) in [https://github.com/slack-go/slack/pull/1208](https://togithub.com/slack-go/slack/pull/1208) - Added `isReadOnly` property to `Conversation` struct by [@​GGonryun](https://togithub.com/GGonryun) in [https://github.com/slack-go/slack/pull/1232](https://togithub.com/slack-go/slack/pull/1232) ##### Bug Fixes - Fixed `UploadFileV2` when using text content by [@​calebmckay](https://togithub.com/calebmckay) in [https://github.com/slack-go/slack/pull/1291](https://togithub.com/slack-go/slack/pull/1291) - Made `Channel` optional on `UploadFileV2` by [@​0xdeafcafe](https://togithub.com/0xdeafcafe) in [https://github.com/slack-go/slack/pull/1293](https://togithub.com/slack-go/slack/pull/1293) ##### Chores / Code Cleanup - Replace a Loop with Slice by [@​testwill](https://togithub.com/testwill) in [https://github.com/slack-go/slack/pull/1211](https://togithub.com/slack-go/slack/pull/1211) - Added Deprecation Notice for `files.upload` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1300](https://togithub.com/slack-go/slack/pull/1300) - Added Go Test Coverage for 1.21 and 1.22 by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1298](https://togithub.com/slack-go/slack/pull/1298) ##### Documentation Updates - Updated Inline Docs and API References by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1299](https://togithub.com/slack-go/slack/pull/1299) - Added an example for `Pagination` by [@​adamrothman](https://togithub.com/adamrothman) in [https://github.com/slack-go/slack/pull/1201](https://togithub.com/slack-go/slack/pull/1201) - Added an example for `ConversationHistory` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1302](https://togithub.com/slack-go/slack/pull/1302) - Added an example for `AddRemoteFile` and `DeleteFile` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https://github.com/slack-go/slack/pull/1303](https://togithub.com/slack-go/slack/pull/1303) #### New Contributors - [@​calebmckay](https://togithub.com/calebmckay) made their first contribution in [https://github.com/slack-go/slack/pull/1291](https://togithub.com/slack-go/slack/pull/1291) - [@​lheiskan](https://togithub.com/lheiskan) made their first contribution in [https://github.com/slack-go/slack/pull/1208](https://togithub.com/slack-go/slack/pull/1208) - [@​GGonryun](https://togithub.com/GGonryun) made their first contribution in [https://github.com/slack-go/slack/pull/1232](https://togithub.com/slack-go/slack/pull/1232) - [@​0xdeafcafe](https://togithub.com/0xdeafcafe) made their first contribution in [https://github.com/slack-go/slack/pull/1293](https://togithub.com/slack-go/slack/pull/1293) - [@​lorenzoaiello](https://togithub.com/lorenzoaiello) made their first contribution in [https://github.com/slack-go/slack/pull/1300](https://togithub.com/slack-go/slack/pull/1300) - [@​adamrothman](https://togithub.com/adamrothman) made their first contribution in [https://github.com/slack-go/slack/pull/1201](https://togithub.com/slack-go/slack/pull/1201) **Full Changelog**: slack-go/slack@v0.13.0...v0.13.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.