-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: replace eslint with the biome for formatting and linting changes #14
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Quick notes for the reviewers: No changes to logic are in this PR other than making the recommended changes from biome
🌲
"lint": "npx @biomejs/biome check *.js", | ||
"lint:fix": "npx @biomejs/biome check --write *.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a similar change that's found in slack-samples/bolt-ts-starter-template#131 - open to making changes here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this migration! Other reviewers may have some suggestions on details but overall this PR looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES! Love me some biome
Type of change
Summary
This PR replaces
eslint
withbiome
to match the changes in slack-samples/bolt-js-starter-template#91 and resume the merges from the wonderful and kind @dependabot 🙏Requirements