Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace eslint with the biome for formatting and linting changes #14

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Nov 5, 2024

Type of change

  • New feature

Summary

This PR replaces eslint with biome to match the changes in slack-samples/bolt-js-starter-template#91 and resume the merges from the wonderful and kind @dependabot 🙏

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added the audit Changes associated with auditing label Nov 5, 2024
@zimeg zimeg self-assigned this Nov 5, 2024
Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Quick notes for the reviewers: No changes to logic are in this PR other than making the recommended changes from biome 🌲

Comment on lines +8 to +9
"lint": "npx @biomejs/biome check *.js",
"lint:fix": "npx @biomejs/biome check --write *.js"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is a similar change that's found in slack-samples/bolt-ts-starter-template#131 - open to making changes here!

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this migration! Other reviewers may have some suggestions on details but overall this PR looks good to me 👍

Copy link
Member

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! Love me some biome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Changes associated with auditing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants