Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use the built and bundled javascript for main #14

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Nov 20, 2024

Type of change

  • Bug fix

Summary

This PR updates the main in package.json to point to the dist/app.js that's created after running the following command:

$ npm run build

Fixes an issue of finding the built app with the @slack/cli-hooks defaults but does not build the app as part of the start hook!

Notes

This PR matches the changes in slack-samples/bolt-ts-starter-template#133 - will mirror whatever happens here!

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added the bug Something isn't working label Nov 20, 2024
@zimeg
Copy link
Member Author

zimeg commented Nov 20, 2024

Merging to match the changes in slack-samples/bolt-ts-starter-template#133 🚀

@zimeg zimeg merged commit a1ffbdb into main Nov 20, 2024
4 checks passed
@zimeg zimeg deleted the zimeg-build-dist-main branch November 20, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant