-
Notifications
You must be signed in to change notification settings - Fork 105
Prep Compose 1.10.0 #2379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Prep Compose 1.10.0 #2379
Conversation
|
Preview release for this is up as |
gradle/libs.versions.toml
Outdated
| compose-hotReload = "1.0.0-rc02" | ||
| compose-jb = "1.9.2" | ||
| compose-jb-material3 = "1.9.0" | ||
| compose-jb = "1.10.0-alpha03" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still getting this error when using 0.31.0-alpha01-composejb-1.10.0-alpha03 with Compose 1.10.0-beta01
ERROR: R8: Missing class androidx.compose.animation.SharedTransitionScope$ComposeDefaultImpls (referenced from: androidx.compose.animation.SharedTransitionScope$SharedContentState com.slack.circuit.sharedelements.SharedElementTransitionScopeImpl.rememberSharedContentState(java.lang.Object, androidx.compose.animation.SharedTransitionScope$SharedContentConfig, androidx.compose.runtime.Composer, int))
Should you update also
androidx-compose = "1.10.0-beta01"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it, though it's also worth mentioning that if you're not using any of these transition APIs then you are not blocked on this, that error is easily suppressed with a -dontwarn directive if you need to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, definitely not a blocker for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're fully building against compose multi-platform, so I think this is just a miss-match between Jetpack Compose 1.10.0-alpha05 (which CMP 1.10.0-alpha03 is at) and Jetpack Compose 1.10.0-beta01.
- Sorted the jetbrains versions together as they update together
This reverts commit 48ff104.
|
New preview release: |
Todos
NavigationEventfromBackHandler