Skip to content

Commit

Permalink
Indicate a few more TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
nbrownus committed Jan 28, 2025
1 parent 06e6437 commit 727c0bf
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lighthouse.go
Original file line number Diff line number Diff line change
Expand Up @@ -1194,6 +1194,7 @@ func (lhh *LightHouseHandler) coalesceAnswers(v cert.Version, c *cache, n *Nebul
}

} else {
//TODO: CERT-V2 don't panic
panic("unsupported version")
}
}
Expand Down Expand Up @@ -1257,8 +1258,8 @@ func (lhh *LightHouseHandler) handleHostUpdateNotification(n *NebulaMeta, fromVp
return
}

//todo hosts with only v2 certs cannot provide their ipv6 addr when contacting the lighthouse via v4?
//todo why do we care about the vpnAddr in the packet? We know where it came from, right?
//TODO: CERT-V2 hosts with only v2 certs cannot provide their ipv6 addr when contacting the lighthouse via v4?
//TODO: CERT-V2 why do we care about the vpnAddr in the packet? We know where it came from, right?
//Simple check that the host sent this not someone else
if !slices.Contains(fromVpnAddrs, detailsVpnAddr) {
if lhh.l.Level >= logrus.DebugLevel {
Expand Down

0 comments on commit 727c0bf

Please sign in to comment.