local_cidr moved to always be evaluated
#1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrownus
changed the title
localcidr moved to always be evaluatedlocalcidr moved to always be evaluated
nbrownus
force-pushed
the
localcidr-mid
branch
from
eb4d67f to
cc8b3cc
Compare
johnmaguire
changed the title
localcidr moved to always be evaluatedlocal_cidr moved to always be evaluated
brad-defined
approved these changes
Feb 21, 2024
| } | ||
| }) | ||
| // |
There was a problem hiding this comment.
intentionally commented out?
|
|
||
| // EachContains will call a function, passing the value, for each entry until the function returns true or the search is complete | ||
| // The final return value will be true if the provided function returned true | ||
| func (tree *Tree4[T]) EachContains(ip iputil.VpnIp, each eachFunc[T]) bool { |
There was a problem hiding this comment.
Nit: EachContains sounds like each and every element must contain. I would call this one AnyContains, FWIW.
johnmaguire
added a commit
to DefinedNet/nebula-docs
that referenced
this pull request
May 1, 2024
johnmaguire
added a commit
to DefinedNet/nebula-docs
that referenced
this pull request
May 1, 2024
johnmaguire
added a commit
to DefinedNet/nebula-docs
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local_cidrwas added to firewall rules recently and the current implementation only looks atlocal_cidrif thehost,groups, andcidrdo not already match. This greatly limits the ability to control what an unsafe router allows for traffic flows.This change moves
local_cidrto its own evaluation group that will be checked after doing host identity matching (host,groups, orcidr). If the local certificate has any subnets then all rules will have the local certificates ip address as thelocal_cidrby default to block any unintended exposure via an unsafe route.This is a breaking change and will require anyone that uses unsafe routes to change their firewall rules to include a
local_cidrfor the traffic they want to allow.