Allow setting grpc send and recv message sizes independently (#481)

* Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com>
slackhq · Oct 24, 2024 · 5e81df3 · 5e81df3
1 parent c6ee558
commit 5e81df3
Show file tree

Hide file tree

Showing 13 changed files with 126 additions and 7 deletions.
diff --git a/go/cmd/vtgateproxy/vtgateproxy b/go/cmd/vtgateproxy/vtgateproxy
diff --git a/go/flags/endtoend/vtbackup.txt b/go/flags/endtoend/vtbackup.txt
@@ -135,6 +135,8 @@ Flags:
       --grpc_initial_window_size int                                gRPC initial window size
       --grpc_keepalive_time duration                                After a duration of this time, if the client doesn't see any activity, it pings the server to see if the transport is still alive. (default 10s)
       --grpc_keepalive_timeout duration                             After having pinged for keepalive check, the client waits for a duration of Timeout and if no activity is seen even after that the connection is closed. (default 10s)
+      --grpc_max_message_recv_size int                              Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int                              Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
       --grpc_max_message_size int                                   Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
       --grpc_prometheus                                             Enable gRPC monitoring with Prometheus.
   -h, --help                                                        help for vtbackup

diff --git a/go/flags/endtoend/vtctlclient.txt b/go/flags/endtoend/vtctlclient.txt
@@ -16,6 +16,8 @@ Usage of vtctlclient:
       --grpc_initial_window_size int                                gRPC initial window size
       --grpc_keepalive_time duration                                After a duration of this time, if the client doesn't see any activity, it pings the server to see if the transport is still alive. (default 10s)
       --grpc_keepalive_timeout duration                             After having pinged for keepalive check, the client waits for a duration of Timeout and if no activity is seen even after that the connection is closed. (default 10s)
+      --grpc_max_message_recv_size int                              Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int                              Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
       --grpc_max_message_size int                                   Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
       --grpc_prometheus                                             Enable gRPC monitoring with Prometheus.
   -h, --help                                                        display usage and exit

diff --git a/go/flags/endtoend/vtctld.txt b/go/flags/endtoend/vtctld.txt
@@ -75,6 +75,8 @@ Flags:
       --grpc_key string                                                  server private key to use for gRPC connections, requires grpc_cert, enables TLS
       --grpc_max_connection_age duration                                 Maximum age of a client connection before GoAway is sent. (default 2562047h47m16.854775807s)
       --grpc_max_connection_age_grace duration                           Additional grace period after grpc_max_connection_age, after which connections are forcibly closed. (default 2562047h47m16.854775807s)
+      --grpc_max_message_recv_size int                                   Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int                                   Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
       --grpc_max_message_size int                                        Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
       --grpc_port int                                                    Port to listen on for gRPC calls. If zero, do not listen.
       --grpc_prometheus                                                  Enable gRPC monitoring with Prometheus.

diff --git a/go/flags/endtoend/vtctldclient.txt b/go/flags/endtoend/vtctldclient.txt
@@ -115,6 +115,8 @@ Flags:
       --grpc_initial_window_size int           gRPC initial window size
       --grpc_keepalive_time duration           After a duration of this time, if the client doesn't see any activity, it pings the server to see if the transport is still alive. (default 10s)
       --grpc_keepalive_timeout duration        After having pinged for keepalive check, the client waits for a duration of Timeout and if no activity is seen even after that the connection is closed. (default 10s)
+      --grpc_max_message_recv_size int         Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int         Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
       --grpc_max_message_size int              Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
       --grpc_prometheus                        Enable gRPC monitoring with Prometheus.
   -h, --help                                   help for vtctldclient

diff --git a/go/flags/endtoend/vtgate.txt b/go/flags/endtoend/vtgate.txt
@@ -88,6 +88,8 @@ Flags:
       --grpc_key string                                                  server private key to use for gRPC connections, requires grpc_cert, enables TLS
       --grpc_max_connection_age duration                                 Maximum age of a client connection before GoAway is sent. (default 2562047h47m16.854775807s)
       --grpc_max_connection_age_grace duration                           Additional grace period after grpc_max_connection_age, after which connections are forcibly closed. (default 2562047h47m16.854775807s)
+      --grpc_max_message_recv_size int                                   Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int                                   Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
       --grpc_max_message_size int                                        Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
       --grpc_port int                                                    Port to listen on for gRPC calls. If zero, do not listen.
       --grpc_prometheus                                                  Enable gRPC monitoring with Prometheus.

diff --git a/go/flags/endtoend/vtgr.txt b/go/flags/endtoend/vtgr.txt
@@ -0,0 +1,80 @@
+Usage of vtgr:
+      --abort_rebootstrap                          Don't allow vtgr to rebootstrap an existing group.
+      --alsologtostderr                            log to standard error as well as files
+      --clusters_to_watch strings                  Comma-separated list of keyspaces or keyspace/shards that this instance will monitor and repair. Defaults to all clusters in the topology. Example: "ks1,ks2/-80"
+      --consul_auth_static_file string             JSON File to read the topos/tokens from.
+      --db_config string                           Full path to db config file that will be used by VTGR.
+      --db_flavor string                           MySQL flavor override. (default "MySQL56")
+      --db_port int                                Local mysql port, set this to enable local fast check.
+      --emit_stats                                 If set, emit stats to push-based monitoring and stats backends
+      --enable_heartbeat_check                     Enable heartbeat checking, set together with --group_heartbeat_threshold.
+      --gr_port int                                Port to bootstrap a MySQL group. (default 33061)
+      --group_heartbeat_threshold int              VTGR will trigger backoff on inconsistent state if the group heartbeat staleness exceeds this threshold (in seconds). Should be used along with --enable_heartbeat_check.
+      --grpc_auth_static_client_creds string       When using grpc_static_auth in the server, this file provides the credentials to use to authenticate with server.
+      --grpc_compression string                    Which protocol to use for compressing gRPC. Default: nothing. Supported: snappy
+      --grpc_enable_tracing                        Enable gRPC tracing.
+      --grpc_initial_conn_window_size int          gRPC initial connection window size
+      --grpc_initial_window_size int               gRPC initial window size
+      --grpc_keepalive_time duration               After a duration of this time, if the client doesn't see any activity, it pings the server to see if the transport is still alive. (default 10s)
+      --grpc_keepalive_timeout duration            After having pinged for keepalive check, the client waits for a duration of Timeout and if no activity is seen even after that the connection is closed. (default 10s)
+      --grpc_max_message_recv_size int             Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int             Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_size int                  Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
+      --grpc_prometheus                            Enable gRPC monitoring with Prometheus.
+  -h, --help                                       display usage and exit
+      --keep_logs duration                         keep logs for this long (using ctime) (zero to keep forever)
+      --keep_logs_by_mtime duration                keep logs for this long (using mtime) (zero to keep forever)
+      --lock-timeout duration                      Maximum time for which a shard/keyspace lock can be acquired for (default 45s)
+      --log_backtrace_at traceLocations            when logging hits line file:N, emit a stack trace
+      --log_dir string                             If non-empty, write log files in this directory
+      --log_err_stacks                             log stack traces for errors
+      --log_link string                            If non-empty, add symbolic links in this directory to the log files
+      --log_rotate_max_size uint                   size in bytes at which logs are rotated (glog.MaxSize) (default 1887436800)
+      --logbuflevel int                            Buffer log messages logged at this level or lower (-1 means don't buffer; 0 means buffer INFO only; ...). Has limited applicability on non-prod platforms.
+      --logtostderr                                log to standard error instead of files
+      --ping_tablet_timeout duration               time to wait when we ping a tablet (default 2s)
+      --pprof strings                              enable profiling
+      --purge_logs_interval duration               how often try to remove old logs (default 1h0m0s)
+      --refresh_interval duration                  Refresh interval to load tablets. (default 10s)
+      --remote_operation_timeout duration          time to wait for a remote operation (default 15s)
+      --scan_interval duration                     Scan interval to diagnose and repair. (default 3s)
+      --scan_repair_timeout duration               Time to wait for a Diagnose and repair operation. (default 3s)
+      --security_policy string                     the name of a registered security policy to use for controlling access to URLs - empty means allow all for anyone (built-in policies: deny-all, read-only)
+      --stats_backend string                       The name of the registered push-based monitoring/stats backend to use
+      --stats_combine_dimensions string            List of dimensions to be combined into a single "all" value in exported stats vars
+      --stats_common_tags strings                  Comma-separated list of common tags for the stats backend. It provides both label and values. Example: label1:value1,label2:value2
+      --stats_drop_variables string                Variables to be dropped from the list of exported variables.
+      --stats_emit_period duration                 Interval between emitting stats to all registered backends (default 1m0s)
+      --stderrthreshold severityFlag               logs at or above this threshold go to stderr (default 1)
+      --tablet_manager_grpc_ca string              the server ca to use to validate servers when connecting
+      --tablet_manager_grpc_cert string            the cert to use to connect
+      --tablet_manager_grpc_concurrency int        concurrency to use to talk to a vttablet server for performance-sensitive RPCs (like ExecuteFetchAs{Dba,AllPrivs,App}) (default 8)
+      --tablet_manager_grpc_connpool_size int      number of tablets to keep tmclient connections open to (default 100)
+      --tablet_manager_grpc_crl string             the server crl to use to validate server certificates when connecting
+      --tablet_manager_grpc_key string             the key to use to connect
+      --tablet_manager_grpc_server_name string     the server name to use to validate server certificate
+      --tablet_manager_protocol string             Protocol to use to make tabletmanager RPCs to vttablets. (default "grpc")
+      --topo_consul_idle_conn_timeout duration     Maximum amount of time to pool idle connections. (default 1m30s)
+      --topo_consul_lock_delay duration            LockDelay for consul session. (default 15s)
+      --topo_consul_lock_session_checks string     List of checks for consul session. (default "serfHealth")
+      --topo_consul_lock_session_ttl string        TTL for consul session.
+      --topo_consul_max_conns_per_host int         Maximum number of consul connections per host. (default 250)
+      --topo_consul_max_idle_conns int             Maximum number of idle consul connections. (default 100)
+      --topo_consul_watch_poll_duration duration   time of the long poll for watch queries. (default 30s)
+      --topo_etcd_lease_ttl int                    Lease TTL for locks and leader election. The client will use KeepAlive to keep the lease going. (default 30)
+      --topo_etcd_tls_ca string                    path to the ca to use to validate the server cert when connecting to the etcd topo server
+      --topo_etcd_tls_cert string                  path to the client cert to use to connect to the etcd topo server, requires topo_etcd_tls_key, enables TLS
+      --topo_etcd_tls_key string                   path to the client key to use to connect to the etcd topo server, enables TLS
+      --topo_global_root string                    the path of the global topology data in the global topology server
+      --topo_global_server_address string          the address of the global topology server
+      --topo_implementation string                 the topology implementation to use
+      --topo_zk_auth_file string                   auth to use when connecting to the zk topo server, file contents should be <scheme>:<auth>, e.g., digest:user:pass
+      --topo_zk_base_timeout duration              zk base timeout (see zk.Connect) (default 30s)
+      --topo_zk_max_concurrency int                maximum number of pending requests to send to a Zookeeper server. (default 64)
+      --topo_zk_tls_ca string                      the server ca to use to validate servers when connecting to the zk topo server
+      --topo_zk_tls_cert string                    the cert to use to connect to the zk topo server, requires topo_zk_tls_key, enables TLS
+      --topo_zk_tls_key string                     the key to use to connect to the zk topo server, enables TLS
+      --v Level                                    log level for V logs
+  -v, --version                                    print binary version
+      --vmodule vModuleFlag                        comma-separated list of pattern=N settings for file-filtered logging
+      --vtgr_config string                         Config file for vtgr.
diff --git a/go/flags/endtoend/vtorc.txt b/go/flags/endtoend/vtorc.txt
@@ -42,6 +42,8 @@ Flags:
       --grpc_initial_window_size int                                gRPC initial window size
       --grpc_keepalive_time duration                                After a duration of this time, if the client doesn't see any activity, it pings the server to see if the transport is still alive. (default 10s)
       --grpc_keepalive_timeout duration                             After having pinged for keepalive check, the client waits for a duration of Timeout and if no activity is seen even after that the connection is closed. (default 10s)
+      --grpc_max_message_recv_size int                              Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int                              Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
       --grpc_max_message_size int                                   Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
       --grpc_prometheus                                             Enable gRPC monitoring with Prometheus.
   -h, --help                                                        help for vtorc

diff --git a/go/flags/endtoend/vttablet.txt b/go/flags/endtoend/vttablet.txt
@@ -185,6 +185,8 @@ Flags:
       --grpc_key string                                                  server private key to use for gRPC connections, requires grpc_cert, enables TLS
       --grpc_max_connection_age duration                                 Maximum age of a client connection before GoAway is sent. (default 2562047h47m16.854775807s)
       --grpc_max_connection_age_grace duration                           Additional grace period after grpc_max_connection_age, after which connections are forcibly closed. (default 2562047h47m16.854775807s)
+      --grpc_max_message_recv_size int                                   Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int                                   Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
       --grpc_max_message_size int                                        Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
       --grpc_port int                                                    Port to listen on for gRPC calls. If zero, do not listen.
       --grpc_prometheus                                                  Enable gRPC monitoring with Prometheus.

diff --git a/go/flags/endtoend/vttestserver.txt b/go/flags/endtoend/vttestserver.txt
@@ -62,6 +62,8 @@ Flags:
       --grpc_key string                                                  server private key to use for gRPC connections, requires grpc_cert, enables TLS
       --grpc_max_connection_age duration                                 Maximum age of a client connection before GoAway is sent. (default 2562047h47m16.854775807s)
       --grpc_max_connection_age_grace duration                           Additional grace period after grpc_max_connection_age, after which connections are forcibly closed. (default 2562047h47m16.854775807s)
+      --grpc_max_message_recv_size int                                   Maximum allowed RPC message size when receiving. If 0, defaults to grpc_max_message_size.
+      --grpc_max_message_send_size int                                   Maximum allowed RPC message size when sending. If 0, defaults to grpc_max_message_size.
       --grpc_max_message_size int                                        Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)
       --grpc_port int                                                    Port to listen on for gRPC calls. If zero, do not listen.
       --grpc_prometheus                                                  Enable gRPC monitoring with Prometheus.