Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r14.0.5: sideport vitessio#15053 to limit vtgate conns #199

Merged
merged 1 commit into from
Feb 12, 2024
Merged

slack-vitess-r14.0.5: sideport vitessio#15053 to limit vtgate conns #199

merged 1 commit into from
Feb 12, 2024
+41 −7

Conversation

timvaillancourt
Copy link
Member

Description

This PR sideports vitessio#15053 to our v14 branch in order to address vtgate crashes

Related Issue(s)

vitessio#15053

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt changed the title Limit concurrent creation of healthcheck gRPC connections slack-vitess-r14.0.5: sideport vitessio#15053 to limit vtgate conns Jan 30, 2024
@timvaillancourt timvaillancourt added v14 upstream-backport An upstream backport labels Jan 30, 2024
@timvaillancourt timvaillancourt marked this pull request as ready for review January 30, 2024 20:15
@timvaillancourt timvaillancourt requested a review from a team as a code owner January 30, 2024 20:15
@timvaillancourt timvaillancourt mentioned this pull request Jan 30, 2024
Closed
4 tasks
@timvaillancourt timvaillancourt requested review from venkatraju and a team February 9, 2024 19:43
@timvaillancourt
slack-vitess-r14.0.5: sideport vitessio#15053 to limit vtgate conns
9ca4b87 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt force-pushed the pr15053-slack-vitess-r14.0.5 branch from 23175db to 9ca4b87 Compare February 12, 2024 14:41
tanjinx
tanjinx approved these changes Feb 12, 2024
View reviewed changes
Copy link

@tanjinx tanjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@timvaillancourt timvaillancourt merged commit b878269 into slack-vitess-r14.0.5 Feb 12, 2024
241 checks passed
@timvaillancourt timvaillancourt deleted the pr15053-slack-vitess-r14.0.5 branch February 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

@venkatraju venkatraju Awaiting requested review from venkatraju

Assignees
No one assigned
Labels
upstream-backport An upstream backport v14 v20-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @venkatraju @tanjinx