restructure discovery to do more up front #315
Conversation
|
|
||
| for poolType := range targets { | ||
| if b.affinityField != "" { | ||
| sort.Slice(targets[poolType], func(i, j int) bool { |
There was a problem hiding this comment.
I think we want to sort here to pull the same-AZ hosts to the front of the list, but I don't think we want to slice out the ones in the other AZ.
If we don't have numConnections hosts in the same AZ, I think we still want the discovery to try to find that many valid targets, even if that means crossing AZs.
There was a problem hiding this comment.
we're not dropping any targets here, only sorting
There was a problem hiding this comment.
🤦 Oh duh of course, my bad
There was a problem hiding this comment.
I should actually get coffee before reviewing code next time.
| return b.affinityValue == targets[poolType][i].Affinity | ||
| }) | ||
| } | ||
| if len(targets[poolType]) > *numConnections { |
There was a problem hiding this comment.
Much simpler than my unnecessary min() function.
There was a problem hiding this comment.
we could use the built in min if we weren't on go 1.18 😢
|
Expanding that a bit, I think this is real close but we need some locking to make this safe, since we have a race between new inbound mysql connections, the parser detecting changes to the file, and the debug page scraping the list. I also think it'd be a nice little win if the debug page also did the AZ affinity sorting that the actual connection logic is going to do. So I think the solution would be:
Then the debug page can use those two helper methods which I think means we'll get a thread safe debug view that would randomly shuffle sort each time like the actual connection code does. |
* move organization of target hosts to parse time * rework metrics and logging of parse errors * add discovery bits to debug status page * reset parseErr in the right place * add sync and change debug page to do the shuffle * unrelated but just move some code around --------- Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>
* move organization of target hosts to parse time * rework metrics and logging of parse errors * add discovery bits to debug status page * reset parseErr in the right place * add sync and change debug page to do the shuffle * unrelated but just move some code around --------- Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>
* move organization of target hosts to parse time * rework metrics and logging of parse errors * add discovery bits to debug status page * reset parseErr in the right place * add sync and change debug page to do the shuffle * unrelated but just move some code around --------- Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>
Description
/debug/statusendpoint