Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keyrange support for vtorc clusters_to_watch #457

Merged
merged 8 commits into from
Jul 29, 2024
Merged

add keyrange support for vtorc clusters_to_watch #457

merged 8 commits into from
Jul 29, 2024

Conversation

pbibra
Copy link

@pbibra pbibra commented Jul 17, 2024

Description

This PR adds support for keyranges in VTOrc's --clusters_to_watch input. It uses the same filters as the VTGate tablet discovery code. The keyspaceShard list population is stripped out into its own function for easier unit testing.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@pbibra
add keyrange support for vtorc clusters_to_watch
e1bbd10 
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
@github-actions github-actions bot added this to the v19.0.4 milestone Jul 17, 2024
@pbibra pbibra marked this pull request as ready for review July 18, 2024 21:19
@pbibra pbibra requested a review from a team as a code owner July 18, 2024 21:19
@pbibra pbibra requested a review from timvaillancourt July 18, 2024 21:20
@timvaillancourt timvaillancourt self-requested a review July 18, 2024 21:48
@pbibra
more test cases
f46ab37 
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
@timvaillancourt timvaillancourt self-requested a review July 18, 2024 22:22
@pbibra
update assert
d26a840 
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
@pbibra
trigger re-build
a8b93f7 
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
@timvaillancourt timvaillancourt merged commit 45c2199 into slack-19.0 Jul 29, 2024
159 of 163 checks passed
@timvaillancourt timvaillancourt deleted the pbibra-vtorc-shard-range-support branch July 29, 2024 17:20
@timvaillancourt timvaillancourt modified the milestones: v19.0.4, v19.0.5 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

Assignees
No one assigned
Labels
custom-patch upstream-me v19
Projects
None yet
Milestone
v19.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@pbibra @timvaillancourt