backport: vtbackup: disable redo log before starting replication (#11330) #531
+160
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MySQL docs:
See: https://dev.mysql.com/doc/refman/8.0/en/innodb-redo-log.html#innodb-disable-redo-logging
We can take advantage of this in vtbackup. This change disables the redo log on MySQL >= 8.0.21 before starting replication, and re-enables the redo log after stopping replication.
non-fatal error, robus status check, copyright current year
try checking redo log status in vtbackup e2e test
retain vtbackup temporary files so we can verify them in e2e test
make e2e test work with upgrade/downgrade tests
check for mysql 8.0.21 in e2e test redo log assertions
fmt.Println debug
perconnnaaaaaa
fix e2e flags
simplify e2e test, revert flags and cnf cruft
capitalize log msgs
dont verify redo log for --initial_backup
address pr comments: fix typo and remove package alias
address pr comments: report redo log enabled when we can't disable
rely on mysql server variable to determine if can disable/enable redo log
split up binary vs. process redo log capability
simplify further
Address my own pedantic nits
Sorry, can't help myself
Description
Related Issue(s)
Checklist
Deployment Notes