Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-19.0: v22 backports for vtorc, part 2 #596

Draft
wants to merge 6 commits into
base: slack-19.0
Choose a base branch
from

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Feb 4, 2025

Description

This PR contains backports of a collection of v22 contributions to improve the topo-efficiency and safety of VTOrc. Also, the upstream version of key-range support was backported, replacing the un-upstreamed support we added

Related Issue(s)

  1. Ensure all topo read calls consider --topo_read_concurrency vitessio/vitess#17276
  2. [release-19.0] vtorc: require topo for Healthy: true in /debug/health (#17129) vitessio/vitess#17351
  3. vtorc: fetch all tablets from cells once + filter during refresh vitessio/vitess#17388
  4. Support KeyRange in --clusters_to_watch flag vitessio/vitess#17604

This also included a revert of #457, to replace this code with the upstream variant: vitessio#17604

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

…io#17276)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@github-actions github-actions bot added this to the v19.0.7 milestone Feb 4, 2025
@timvaillancourt timvaillancourt changed the title slack-19.0: topo efficiency backports for vtorc, part 2 slack-19.0: v22 backports for vtorc, part 2 Feb 4, 2025
vitess-bot bot and others added 3 commits February 4, 2025 14:40
…ealth` (vitessio#17129) (vitessio#17351)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
…itessio#17388)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link

salesforce-cla bot commented Feb 4, 2025

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants