Skip to content

Backport vstream prs v21 #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: slack-21.0
Choose a base branch
from
Open

Backport vstream prs v21 #651

wants to merge 6 commits into from

Conversation

twthorn
Copy link

@twthorn twthorn commented May 13, 2025 •
edited
Loading

Description

We need to backport these PRs
https://github.com/slackhq/vitess/pulls?q=author%3Atwthorn+is%3Amerged+base%3Aslack-19.0

The last one was already in v21, so there are only 2 of the three we need to backport. Added them here.

Also add a new one that Planetscale implemented for us:

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

twthorn added 2 commits May 13, 2025 17:02
@twthorn
VReplication: Support excluding lagging tablets and use this in vstre…
9a59a67 
…am manager (vitessio#17835) (#612)
@twthorn
Bp pr 17558 pr 17858.slack19.0 (#615)
9166ea9 
* VReplication: Improve error handling in VTGate VStreams (vitessio#17558)

Signed-off-by: Tom Thornton <thomaswilliamthornton@gmail.com>

* Backport vitessio#17858

---------

Signed-off-by: Tom Thornton <thomaswilliamthornton@gmail.com>
@twthorn twthorn requested a review from a team as a code owner May 13, 2025 21:08
@beingnoble03 @twthorn
VStream: Add flag to support copying only specific tables (vitessio#1…
e7b19b9 
…8184)

Signed-off-by: Noble Mittal <noblemittal@outlook.com>
@salesforce-cla Salesforce CLA
Copy link

Thanks for the contribution! Before we can merge this, we need @beingnoble03 to sign the Salesforce Inc. Contributor License Agreement.

@twthorn
Add a flag to vstream to exclude keyspace from table name (vitessio#1…
1fe3f69 
…8274)

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
timvaillancourt
timvaillancourt previously approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twthorn

@twthorn
Add support for sending grpc server backend metrics via ORCA (vitessi…
3f1d2d8 
…o#18282)

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt left review comments

@tanjinx tanjinx Awaiting requested review from tanjinx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twthorn @timvaillancourt @beingnoble03