Skip to content

fea: 웹 상단 icon 및 titile 설정 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starboxxxx merged 1 commit into from
Dec 29, 2025
Merged

fea: 웹 상단 icon 및 titile 설정 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<html lang="ko">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<link rel="icon" href="/public/favicon.ico" />
Copy link

@gemini-code-assist gemini-code-assist bot Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

파비콘 경로가 잘못되었습니다. Vite는 public 디렉터리의 파일을 프로젝트 루트 경로(/)에서 제공하므로, href 속성 값은 /favicon.ico가 되어야 합니다.

추가적으로, .ico 파일의 경우 type="image/x-icon" 속성을 명시해주는 것이 좋습니다.

Suggested change
<link rel="icon" href="/public/favicon.ico" />
<link rel="icon" type="image/x-icon" href="/favicon.ico" />

<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Frontend</title>
<title>SlackJudge</title>
</head>
<body>
<div id="root"></div>
Expand Down
Binary file added public/favicon.ico
View file
Open in desktop
Binary file not shown.
Loading