Skip to content

Style: Row 색 변경 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marulog merged 1 commit into from
Dec 30, 2025
Merged

Style: Row 색 변경 #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/ranking/RankingRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ const RankingRow = ({ row }: RankingRowProps) => {
className={[
"relative grid grid-cols-7 items-center py-4 border-b text-sm",
row.newUser
? "border-green-100 bg-gradient-to-r from-green-100/80 to-transparent"
: "border-gray-500",
? "border-gray-200 bg-gradient-to-r from-green-100/80 to-transparent"
: "border-gray-200",
].join(" ")}
Comment on lines 28 to 33
Copy link

@gemini-code-assist gemini-code-assist bot Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

border 색상을 border-gray-200으로 통일하신 변경 잘 보았습니다. 현재 코드에서는 row.newUser의 값과 관계없이 항상 border-gray-200 클래스가 적용되고 있습니다. 이로 인해 삼항 연산자 내부에 중복이 발생했습니다.

공통으로 적용되는 border-gray-200 클래스를 밖으로 빼내고, row.newUser가 참일 때만 적용되는 클래스만 삼항 연산자 안에 남겨두면 코드가 더 간결해지고 의도가 명확해집니다.

  className={[
    "relative grid grid-cols-7 items-center py-4 border-b text-sm border-gray-200",
    row.newUser ? "bg-gradient-to-r from-green-100/80 to-transparent" : "",
  ].join(" ")}

>
<div className="relative text-center">
Expand Down
Loading