Skip to content

Conversation

@tsgit
Copy link
Contributor

@tsgit tsgit commented Jun 11, 2023

clarify phoebus alarm server startup.

ensure that logging configuration is properly handled

insert a noop into the if branch instead a nonsensical extraneous command. note that -xml_file is not a recognized argument and never was.

Signed-off-by: Thorsten Schwander <thorsten.schwander@gmail.com>
@tsgit
Copy link
Contributor Author

tsgit commented Jun 12, 2023

the -import option is shown here

# java -jar /opt/phoebus/service-alarm-server.jar -help
 _______  _        _______  _______  _______    _______  _______  _______           _______  _______
(  ___  )( \      (  ___  )(  ____ )(       )  (  ____ \(  ____ \(  ____ )|\     /|(  ____ \(  ____ )
| (   ) || (      | (   ) || (    )|| () () |  | (    \/| (    \/| (    )|| )   ( || (    \/| (    )|
| (___) || |      | (___) || (____)|| || || |  | (_____ | (__    | (____)|| |   | || (__    | (____)|
|  ___  || |      |  ___  ||     __)| |(_)| |  (_____  )|  __)   |     __)( (   ) )|  __)   |     __)
| (   ) || |      | (   ) || (\ (   | |   | |        ) || (      | (\ (    \ \_/ / | (      | (\ (   
| )   ( || (____/\| )   ( || ) \ \__| )   ( |  /\____) || (____/\| ) \ \__  \   /  | (____/\| ) \ \__
|/     \|(_______/|/     \||/   \__/|/     \|  \_______)(_______/|/   \__/   \_/   (_______/|/   \__/        

Command-line arguments:

-help                                   - This text
-server             localhost:9092      - Kafka server with port number
-config             Accelerator         - Alarm configuration
-settings           settings.{xml,ini}  - Import preferences (PV connectivity) from property format file
-noshell                                - Disable the command shell for running without a terminal
-export             config.xml          - Export alarm configuration to file
-import             config.xml          - Import alarm configruation from file
-logging            logging.properties  - Load log settings
-connect_secs       10                  - Time alarm server and config import/export waits for connection
-stable_secs         4                  - Time alarm server and config import/export waits for stable configuration
-kafka_properties   client.properties   - Load kafka client settings from file

clearly there is no -xml_file argument

@jbellister-slac jbellister-slac self-requested a review June 12, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant