added width and height attributes (#42)

sliemeobn · Sep 21, 2024 · 4d9d137 · 4d9d137
1 parent d82525e
commit 4d9d137
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/Sources/Elementary/HtmlAttributes.swift b/Sources/Elementary/HtmlAttributes.swift
@@ -92,7 +92,7 @@ public extension HTMLAttribute where Tag == HTMLTag.meta {
 // link tag attributes
 // https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link
 public extension HTMLAttribute where Tag == HTMLTag.link {
-    public struct As: Sendable, ExpressibleByStringLiteral {
+    struct As: Sendable, ExpressibleByStringLiteral {
         var value: String
 
         init(value: String) {
@@ -118,7 +118,7 @@ public extension HTMLAttribute where Tag == HTMLTag.link {
         public static let author = As(value: "author")
     }
 
-    public static func `as`(_ value: As) -> Self {
+    static func `as`(_ value: As) -> Self {
         HTMLAttribute(name: "as", value: value.value)
     }
 }
@@ -461,6 +461,29 @@ extension HTMLAttribute where Tag: HTMLTrait.Attributes.referrerpolicy {
     }
 }
 
+// width and height attributes
+public extension HTMLTrait.Attributes {
+    protocol dimensions {}
+}
+
+extension HTMLTag.canvas: HTMLTrait.Attributes.dimensions {}
+extension HTMLTag.embed: HTMLTrait.Attributes.dimensions {}
+extension HTMLTag.iframe: HTMLTrait.Attributes.dimensions {}
+extension HTMLTag.img: HTMLTrait.Attributes.dimensions {}
+extension HTMLTag.input: HTMLTrait.Attributes.dimensions {}
+extension HTMLTag.object: HTMLTrait.Attributes.dimensions {}
+extension HTMLTag.video: HTMLTrait.Attributes.dimensions {}
+
+public extension HTMLAttribute where Tag: HTMLTrait.Attributes.dimensions {
+    static func width(_ value: Int) -> Self {
+        HTMLAttribute(name: "width", value: "\(value)")
+    }
+
+    static func height(_ value: Int) -> Self {
+        HTMLAttribute(name: "height", value: "\(value)")
+    }
+}
+
 // form tag attributes
 public extension HTMLAttribute where Tag == HTMLTag.form {
     struct Method: Sendable, Equatable {

diff --git a/Tests/ElementaryTests/AttributeRenderingTests.swift b/Tests/ElementaryTests/AttributeRenderingTests.swift
@@ -123,4 +123,11 @@ final class AttributeRenderingTests: XCTestCase {
             #"<img id="1" style="2">"#
         )
     }
+
+    func testRendersWidthAndHeightAttributes() async throws {
+        try await HTMLAssertEqual(
+            img(.width(100), .height(200)),
+            #"<img width="100" height="200">"#
+        )
+    }
 }