Merged
Conversation
- ReportGenerator: Add totalLiabilities parameter and calculate net worth - useMigration: Import actual PaymentEncryptionService instead of stub - NisabYearRecordsPage: Pass liability total to PDF generator Remaining TODOs skipped: - useZakatSnapshots comparison logic (needs API design) - calendarConverter test functions (new feature work)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
totalLiabilitiesparameter togenerateHawlStatement()and calculate net worth properlyPaymentEncryptionServiceinstead of stub functionChanges
ReportGenerator.ts:
totalLiabilitiesparameter (default 0)totalAssetsfrom assets arraynetWorth= totalAssets - totalLiabilitiesuseMigration.ts:
PaymentEncryptionService.encryptPaymentData()NisabYearRecordsPage.tsx:
Not Included (skipped)
useZakatSnapshotscomparison logic - needs API design workcalendarConvertertest functions - new feature implementation, not just TODOsTesting