Skip to content

Comments

fix: Resolve client-side TODOs#292

Merged
slimatic merged 1 commit intomainfrom
feature/multi-currency-integration
Feb 17, 2026
Merged

fix: Resolve client-side TODOs#292
slimatic merged 1 commit intomainfrom
feature/multi-currency-integration

Conversation

@slimatic
Copy link
Owner

Summary

  • ReportGenerator: Add totalLiabilities parameter to generateHawlStatement() and calculate net worth properly
  • useMigration: Import actual PaymentEncryptionService instead of stub function
  • NisabYearRecordsPage: Pass liability total to PDF generator

Changes

  1. ReportGenerator.ts:

    • Added totalLiabilities parameter (default 0)
    • Calculate totalAssets from assets array
    • Calculate netWorth = totalAssets - totalLiabilities
    • Display liabilities and net worth in both Summary and Financials sections
  2. useMigration.ts:

    • Replace stub with actual PaymentEncryptionService.encryptPaymentData()
  3. NisabYearRecordsPage.tsx:

    • Calculate total liabilities from allLiabilities
    • Pass to PDF generator

Not Included (skipped)

  • useZakatSnapshots comparison logic - needs API design work
  • calendarConverter test functions - new feature implementation, not just TODOs

Testing

  • TypeScript compiles without errors
  • Changes are backward compatible (optional parameter with default)

- ReportGenerator: Add totalLiabilities parameter and calculate net worth
- useMigration: Import actual PaymentEncryptionService instead of stub
- NisabYearRecordsPage: Pass liability total to PDF generator

Remaining TODOs skipped:
- useZakatSnapshots comparison logic (needs API design)
- calendarConverter test functions (new feature work)
@slimatic slimatic merged commit 0eba67c into main Feb 17, 2026
2 checks passed
@slimatic slimatic deleted the feature/multi-currency-integration branch February 17, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant