Skip to content

Conversation

@hunger
Copy link
Member

@hunger hunger commented Oct 24, 2025

No description provided.

@ogoffart
Copy link
Member

In principle, this is a great change to limit the pressure on our CI.

That said, the autofix currently takes 5 minutes. So this would delay by 5 minutes the result of the CI for every change that didn't have anything to fix.

One of the slow part of the autofix is the lint_typecheck , Why is it in the autofix workflow in the first place? Could it be moved to the ci workflow instead?

@ogoffart
Copy link
Member

Note that the normal CI didn't run in this PR, so something didn't work :-/

@ogoffart
Copy link
Member

Note that the normal CI didn't run in this PR, so something didn't work :-/

I think the reason is that workflow_run only work in the default branch.
Meaning that it will only run if it was commited to master. And then the action would actually test the master branch, and not the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants