Add 1st level symlink follow on walkdirs

Signed-off-by: Xabier Larrakoetxea <me@slok.dev>

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## [Unreleased]
 
+### Added
+
+- Follow 1st level symlinks when discovery paths like private keys directories (adding symlink follow at all levels adds too many edge cases).
+
 ## [v0.7.2] - 2024-12-19
 
 ### Changed

internal/storage/fs/secret.go

@@ -36,6 +36,14 @@ func (fileManager) StatFile(_ context.Context, path string) (os.FileInfo, error)
 	return os.Stat(path)
 }
 func (fileManager) WalkDir(_ context.Context, root string, fn fs.WalkDirFunc) error {
+	// Symlinks walkdirs have lots of edge cases so as a middle ground between reliability, simplicity and practicality
+	// we will only support first level symlinks (as ~/.ssh being a symlink can be a common use case).
+	// More info here: https://github.com/golang/go/issues/49580
+	evalRoot, err := filepath.EvalSymlinks(root)
+	if err == nil {
+		root = evalRoot
+	}
+
 	return filepath.WalkDir(root, fn)
 }