Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update GitHub actions which still used deprecated Node.js" #300

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

beatrycze-volk
Copy link
Contributor

Reverts #292

@beatrycze-volk beatrycze-volk merged commit 14cd7dd into master Aug 8, 2024
6 of 7 checks passed
@beatrycze-volk beatrycze-volk self-assigned this Aug 8, 2024
@beatrycze-volk beatrycze-volk added the 🐛 bug A non-security related bug. label Aug 8, 2024
@beatrycze-volk beatrycze-volk added this to the DFG-Viewer 6.1.1 milestone Aug 8, 2024
@stweil
Copy link
Contributor

stweil commented Aug 8, 2024

Why did you revert my commit, just to apply the same changes again in commit 9a5adb5?

@beatrycze-volk
Copy link
Contributor Author

I needed to revert all changes introduced after #230 in order to revert it, After reverting it I wanted to avoid loss of the changes introduced. So I have created the PR containing all changes related to Node JS #304.

@stweil
Copy link
Contributor

stweil commented Aug 9, 2024

It would have been sufficient and much easier to revert only the changes from PR #230, perhaps with manual fixes for a small number of conflicts.

@beatrycze-volk
Copy link
Contributor Author

It was not possible. I tried to do it that way. I got error message that because of the changes made after the #230, the revert PR can not be created. So I have decided to revert changes one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants