check duplicate keys #1270
Merged
check duplicate keys #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
requested changes
Dec 16, 2024
implementation/src/main/java/io/smallrye/config/ConfigValueConfigSource.java
Outdated
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/config/ConfigValuePropertiesUtils.java
Outdated
Show resolved
Hide resolved
fugerit79
force-pushed
the
1-check-duplicate-keys
branch
from
c9ccf3c to
1285338
Compare
radcortez
requested changes
Dec 19, 2024
implementation/src/main/java/io/smallrye/config/ConfigValueConfigSource.java
Outdated
Show resolved
Hide resolved
|
There is an issue with the code style, can you please do a local build to fix it? I've tried it myself, but apparently I can't push changes to your fork. |
Yes, sorry, my bad. After the last commit, I forgot to run: mvn -f implementation net.revelc.code.formatter:formatter-maven-plugin:2.22.0:format
mvn formatter:validate verifyNow the local check completed without alerts. (tried with java 11, 17 and 21). I also rebased onto main and checked again. |
Only for properties config source : duplicate keys found in te same config source will be logged as warning.
Added a log method in ConfigLogging to handle duplicate values.
fugerit79
force-pushed
the
1-check-duplicate-keys
branch
from
2b78690 to
37634ef
Compare
radcortez
approved these changes
Dec 19, 2024
|
Great! Thank you for the PR and your patience, really appreciated it :) |
radcortez
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit :
Only for properties config source : duplicate keys found in te same config source will be logged as warning.
NOTE: this is just a proposal of implementation.