Implement Extensible.hasExtension
#2166
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensible.getExtension already has an implementation. Allow hasExtension and getExtension to handle internal extensions, as addExtension and removeExtension do. This means that they're not exactly equivalent to getExtensions().hasKey and getExtensions().get.
Azquelt
force-pushed
the
has-extension
branch
from
d8f9b2c to
ed67758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing microprofile/microprofile-open-api#666,
Extensible.getExtensionalready has an implementation.Allow
hasExtensionandgetExtensionto handle internal extensions, asaddExtensionandremoveExtensiondo. This means that they're not exactly equivalent togetExtensions().hasKeyandgetExtensions().get.I think the tests added to the TCK are sufficient here.
Left in draft because it requires an update to a snapshot version of the spec, or the removal of
@Override. I'm happy to remove the@Overrideannotations, unless we're going to update to a snapshot version anyway for #2163.