Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector contributor guide #2362

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Connector contributor guide #2362

merged 3 commits into from
Nov 8, 2023

Conversation

ozangunalp
Copy link
Collaborator

  • Moved SenderProcessor to provider module
  • Added Maven archetype module for creating connectors

@ozangunalp ozangunalp force-pushed the connector_contributor_guide branch from 7525953 to 504b3be Compare November 3, 2023 11:11
cescoffier
cescoffier previously approved these changes Nov 3, 2023
View reviewed changes
@ozangunalp
Copy link
Collaborator Author

I think the CI is still flaky because of the eventloop thread count issue.

@ozangunalp ozangunalp force-pushed the connector_contributor_guide branch from 504b3be to aa7e77d Compare November 3, 2023 12:17
@ozangunalp ozangunalp force-pushed the connector_contributor_guide branch 2 times, most recently from c4168e7 to f209822 Compare November 7, 2023 11:00
@ozangunalp
Copy link
Collaborator Author

Test flakiness resolved in #2368

@ozangunalp ozangunalp force-pushed the connector_contributor_guide branch from f209822 to 4cd206a Compare November 7, 2023 12:48
@ozangunalp ozangunalp added this to the 4.11.0 milestone Nov 7, 2023
@ozangunalp ozangunalp force-pushed the connector_contributor_guide branch from 4cd206a to 946f99f Compare November 7, 2023 14:28
@ozangunalp ozangunalp requested a review from cescoffier November 7, 2023 16:54
@cescoffier
Copy link
Contributor

Can you rebase?

@ozangunalp ozangunalp force-pushed the connector_contributor_guide branch from 946f99f to 5382155 Compare November 8, 2023 09:56
@ozangunalp
Copy link
Collaborator Author

Done, sorry I didn't see the conflict

@cescoffier cescoffier merged commit 1ac7534 into smallrye:main Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier Awaiting requested review from cescoffier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ozangunalp @cescoffier