Draft - AWS - SQS support #2402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A lot of things are missing though: logging, finalize tracing, error handling, retry, config. After that polling could be implemented. I am afraid that the tracing cannot be implemented properly due to reactive, but we will see. Tests are missing completely.
…cannot handle some things. The reason is that the metadata is not available but instead is created by this impl and more for providing information from lib to user. So I moved it to configuration. This is not really nice, because I need to configure 4 maps. The config impl. here cannot handle that, so manual parsing is necessary. This is strange. Maybe this needs to change. Receive message implemented sort of. Deletion / Confirmation is missing. Should be the same as Sending. Also with batching.
… bug fixes and config adjustments to make it work. Start with graceful shutdown, which was needed for the tests to prevent localstack from connection loss. Well only needed for faster tests with one localstack instance. New test module to provide common aws specific logs. Except the WeldTestBase, which seems to be a duplicated multiple times.
…o make sure that this works in general.
…uses a custom deserializer, which is then registered via Identifier annotation. I am not sure if this is worth it. In theory deserialization could be added in the invoked method anyway. Same for serialization. Although it is nice to have an included solution the overhead here is quite high.
|
Some questions.
|
…ckson is more forgiving and can serialize a string to a string, but jakarta crashes in this case. This broke the tests.
|
Thanks for this, I'll give it a spin as soon as possible and make some remarks. |
|
Hi @ozangunalp , Thx for the feedback. Yes I noticed the guide. I read it partially already. I think I covered most things already by accident. Well or by checking some other connector implementations. I will recheck to make sure that I am not missing something. A huge topic is the configuration of the AWS SDK client. I did not tackle that yet, because I am not sure what the best approach is. |
|
Hi Team, I stop this contribution. I have no energy to continue it. Sorry for that. Br, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I started with an implementation. There is still a lot of work to do. So help would be welcome. I created the pr, because maybe reviews, questions, help is easier this way.
Progress: