Kafka config override #2406
Merged
Kafka config override #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
previously approved these changes
Dec 8, 2023
| @@ -133,7 +133,7 @@ | |||
| <!-- Ensure log4j1 log backend with slf4j --> | |||
| <dependency> | |||
| <groupId>org.slf4j</groupId> | |||
| <artifactId>slf4j-log4j12</artifactId> | |||
| <artifactId>slf4j-reload4j</artifactId> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
If I recall correctly before we changed the whole log4j12 dependency to reload4j which did not work for the quickstart samples. But I realize that we don't have any test Kafka/pulsar logs without the recent versions of reload4j.
ozangunalp
force-pushed
the
kafka_config_override
branch
from
3a34d48 to
3dfeebf
Compare
cescoffier
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow creating nested connector configs for configuring inner clients/channels. Useful for Kafka clients created for Kafka DLQ and Delayed Retry