Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the RabbitMQ connector #2417

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Refactor the RabbitMQ connector #2417

merged 1 commit into from
Dec 19, 2023

Conversation

cescoffier
Copy link
Contributor

No description provided.

ozangunalp
ozangunalp approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me.
As a future step I'd remove RabbitMQConsumerHelper by moving
declareExchangeIfNeeded and getExchangeName to the RabbitMQClientHelper, and the remaining methods to the IncomingRabbitMQChannel.

@ozangunalp ozangunalp merged commit f9234b7 into smallrye:main Dec 19, 2023
4 checks passed
@cescoffier
Copy link
Contributor Author

@ozangunalp I can do that right now.

@cescoffier
Copy link
Contributor Author

ah ah.... I just pushed another change.

@cescoffier
Copy link
Contributor Author

let me re-open another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozangunalp ozangunalp ozangunalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cescoffier @ozangunalp