Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s, kubernetes and docker as accepted log formats #48

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Jan 5, 2024

To allow for interoperability with Panoramix logging in a single project, smallstep/logging now accepts the new Panoramix formats in addition to the existing ones. The actual formatting isn't changed; it merely accepts the values as valid formats.

This replaces https://github.com/smallstep/panoramix/pull/40. The benefit of adding them here is that we'll only need to update the library once. We don't need to change a deployment (in the future) to move from PANORAMIX_LOG_FORMAT to LOG_FORMAT.

To allow for interoperability with Panoramix logging in a single
project, `smallstep/logging` now accepts the new Panoramix formats
in addition to the existing ones. The actual formatting isn't changed;
it merely accepts the values as valid formats.
@hslatman hslatman requested review from maraino and a team as code owners January 5, 2024 10:56
@hslatman hslatman merged commit f57b71c into master Jan 8, 2024
16 checks passed
@hslatman hslatman deleted the herman/panoramix-log-formats branch January 8, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants