Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log propagated request ID and allow interoperability with legacy tracing #53

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Feb 29, 2024

This adds a new requestid package, which can be used to propagate the request ID (using the new logic) to the legacy logging functionality. The old request ID will now be logged only if the new request ID could not be retrieved from the context.

It's likely this will only have to be used (by dependent systems) for a short while, since panoramix implements our new logging and tracing functionality.

@hslatman hslatman requested review from maraino and a team as code owners February 29, 2024 13:51
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say to use one or the other, adding preference to the new one. The client side of grpclog should also support sending the request id to the server.

@hslatman
Copy link
Member Author

hslatman commented Mar 4, 2024

I would say to use one or the other, adding preference to the new one. The client side of grpclog should also support sending the request id to the server.

I view this as a temporary solution. When our observability stack is implemented more broadly, we can drop logging. Currently we still kind of need both, so that's why I think it makes sense to have them both for now.

@hslatman hslatman requested a review from maraino March 4, 2024 20:33
@hslatman hslatman enabled auto-merge March 5, 2024 14:50
@hslatman hslatman merged commit 0b7093e into master Mar 5, 2024
13 checks passed
@hslatman hslatman deleted the herman/legacy-request-id-interop branch March 5, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants